From 238aab994895c4aa4e2ac4036bb511077ddde10a Mon Sep 17 00:00:00 2001 From: Bjorn A Mellem Date: Tue, 2 Jul 2019 11:06:00 -0700 Subject: [PATCH] Fix bug in use_datagram_transport configuration. Currently, use_datagram_transport's non-default value is never used. Instead of reading configuration.use_datagram_transport, PeerConnection::Initialize reads the local configuration's use_datagram_transport. This hasn't been set yet, and so it always falls back to the default value. Bug: webrtc:9719 Change-Id: I028ed537c7d88ee3421b6bd92fc7d5e3c6970529 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/144441 Reviewed-by: Steve Anton Commit-Queue: Bjorn Mellem Cr-Commit-Position: refs/heads/master@{#28451} --- pc/peer_connection.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc/peer_connection.cc b/pc/peer_connection.cc index 7ea9f50852..0c8202779f 100644 --- a/pc/peer_connection.cc +++ b/pc/peer_connection.cc @@ -1034,7 +1034,7 @@ bool PeerConnection::Initialize( config.active_reset_srtp_params = configuration.active_reset_srtp_params; use_datagram_transport_ = datagram_transport_config_.enabled && - configuration_.use_datagram_transport.value_or( + configuration.use_datagram_transport.value_or( datagram_transport_config_.default_value); if (use_datagram_transport_ || configuration.use_media_transport || configuration.use_media_transport_for_data_channels) {