admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[DVQA] Remove old OnDecoderError method

Browse Source 
Bug: b/243855428
Change-Id: Id028f245df3bb729d558c2f6d0b0c167a7edc187
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273341
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Andrey Logvin <landrey@google.com>
Cr-Commit-Position: refs/heads/main@{#37933}
This commit is contained in:
Artem Titov 2022-08-29 15:36:13 +02:00 committed by WebRTC LUCI CQ
parent d6e9749942
commit 209d71d27f
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
api/test/video_quality_analyzer_interface.h
View File

@ -131,10 +131,6 @@ class VideoQualityAnalyzerInterface
// All available codes are listed in // All available codes are listed in
// modules/video_coding/include/video_error_codes.h // modules/video_coding/include/video_error_codes.h
// `peer_name` is name of the peer on which side error acquired. // `peer_name` is name of the peer on which side error acquired.
// TODO(titovartem): remove this method when downstreams are migrated.
virtual void OnDecoderError(absl::string_view peer_name,
uint16_t frame_id,
int32_t error_code) {}
virtual void OnDecoderError(absl::string_view peer_name, virtual void OnDecoderError(absl::string_view peer_name,
uint16_t frame_id, uint16_t frame_id,
int32_t error_code, int32_t error_code,

3
test/pc/e2e/analyzer/video/example_video_quality_analyzer.cc
View File

@ -105,7 +105,8 @@ void ExampleVideoQualityAnalyzer::OnEncoderError(
void ExampleVideoQualityAnalyzer::OnDecoderError(absl::string_view peer_name, void ExampleVideoQualityAnalyzer::OnDecoderError(absl::string_view peer_name,
uint16_t frame_id, uint16_t frame_id,
int32_t error_code) { int32_t error_code,
const DecoderStats& stats) {
RTC_LOG(LS_ERROR) << "Failed to decode frame " << frame_id RTC_LOG(LS_ERROR) << "Failed to decode frame " << frame_id
<< ". Code: " << error_code; << ". Code: " << error_code;
} }

3
test/pc/e2e/analyzer/video/example_video_quality_analyzer.h
View File

@ -60,7 +60,8 @@ class ExampleVideoQualityAnalyzer : public VideoQualityAnalyzerInterface {
int32_t error_code) override; int32_t error_code) override;
void OnDecoderError(absl::string_view peer_name, void OnDecoderError(absl::string_view peer_name,
uint16_t frame_id, uint16_t frame_id,
int32_t error_code) override; int32_t error_code,
const DecoderStats& stats) override;
void Stop() override; void Stop() override;
std::string GetStreamLabel(uint16_t frame_id) override; std::string GetStreamLabel(uint16_t frame_id) override;