From 209d71d27fc545dc5200df816ac7e60b083f5795 Mon Sep 17 00:00:00 2001 From: Artem Titov Date: Mon, 29 Aug 2022 15:36:13 +0200 Subject: [PATCH] [DVQA] Remove old OnDecoderError method Bug: b/243855428 Change-Id: Id028f245df3bb729d558c2f6d0b0c167a7edc187 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/273341 Commit-Queue: Artem Titov Reviewed-by: Andrey Logvin Cr-Commit-Position: refs/heads/main@{#37933} --- api/test/video_quality_analyzer_interface.h | 4 ---- test/pc/e2e/analyzer/video/example_video_quality_analyzer.cc | 3 ++- test/pc/e2e/analyzer/video/example_video_quality_analyzer.h | 3 ++- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/api/test/video_quality_analyzer_interface.h b/api/test/video_quality_analyzer_interface.h index ab896f7dcf..65cc8123f8 100644 --- a/api/test/video_quality_analyzer_interface.h +++ b/api/test/video_quality_analyzer_interface.h @@ -131,10 +131,6 @@ class VideoQualityAnalyzerInterface // All available codes are listed in // modules/video_coding/include/video_error_codes.h // `peer_name` is name of the peer on which side error acquired. - // TODO(titovartem): remove this method when downstreams are migrated. - virtual void OnDecoderError(absl::string_view peer_name, - uint16_t frame_id, - int32_t error_code) {} virtual void OnDecoderError(absl::string_view peer_name, uint16_t frame_id, int32_t error_code, diff --git a/test/pc/e2e/analyzer/video/example_video_quality_analyzer.cc b/test/pc/e2e/analyzer/video/example_video_quality_analyzer.cc index 0b9e2cd5a2..9f25ca6327 100644 --- a/test/pc/e2e/analyzer/video/example_video_quality_analyzer.cc +++ b/test/pc/e2e/analyzer/video/example_video_quality_analyzer.cc @@ -105,7 +105,8 @@ void ExampleVideoQualityAnalyzer::OnEncoderError( void ExampleVideoQualityAnalyzer::OnDecoderError(absl::string_view peer_name, uint16_t frame_id, - int32_t error_code) { + int32_t error_code, + const DecoderStats& stats) { RTC_LOG(LS_ERROR) << "Failed to decode frame " << frame_id << ". Code: " << error_code; } diff --git a/test/pc/e2e/analyzer/video/example_video_quality_analyzer.h b/test/pc/e2e/analyzer/video/example_video_quality_analyzer.h index f41e29e8ab..99a10c6a74 100644 --- a/test/pc/e2e/analyzer/video/example_video_quality_analyzer.h +++ b/test/pc/e2e/analyzer/video/example_video_quality_analyzer.h @@ -60,7 +60,8 @@ class ExampleVideoQualityAnalyzer : public VideoQualityAnalyzerInterface { int32_t error_code) override; void OnDecoderError(absl::string_view peer_name, uint16_t frame_id, - int32_t error_code) override; + int32_t error_code, + const DecoderStats& stats) override; void Stop() override; std::string GetStreamLabel(uint16_t frame_id) override;