admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused 4-argument version of OnIceCandidateError.

Browse Source 
It has not been used since
https://chromium-review.googlesource.com/c/chromium/src/+/1944346.

Bug: webrtc:13446
Change-Id: Ice9c418435bc7958562eb73524d7651a79508ab6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241440
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35541}
This commit is contained in:
Byoungchan Lee 2021-12-15 06:16:05 +09:00 committed by WebRTC LUCI CQ
parent d525e2d9f7
commit 1fe08e1abe
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
api/peer_connection_interface.h
View File

@ -1295,14 +1295,6 @@ class PeerConnectionObserver {
// A new ICE candidate has been gathered.
virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0;
// Gathering of an ICE candidate failed.
// See https://w3c.github.io/webrtc-pc/#event-icecandidateerror
// `host_candidate` is a stringified socket address.
virtual void OnIceCandidateError(const std::string& host_candidate,
const std::string& url,
int error_code,
const std::string& error_text) {}
// Gathering of an ICE candidate failed.
// See https://w3c.github.io/webrtc-pc/#event-icecandidateerror
virtual void OnIceCandidateError(const std::string& address,

2
pc/peer_connection.cc
View File

@ -1938,8 +1938,6 @@ void PeerConnection::OnIceCandidateError(const std::string& address,
return;
}
Observer()->OnIceCandidateError(address, port, url, error_code, error_text);
// Leftover not to break wpt test during migration to the new API.
Observer()->OnIceCandidateError(address + ":", url, error_code, error_text);
}
void PeerConnection::OnIceCandidatesRemoved(