From 1fe08e1abe5e9c9ebdf0a58344c0c273981406f3 Mon Sep 17 00:00:00 2001 From: Byoungchan Lee Date: Wed, 15 Dec 2021 06:16:05 +0900 Subject: [PATCH] Remove unused 4-argument version of OnIceCandidateError. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It has not been used since https://chromium-review.googlesource.com/c/chromium/src/+/1944346. Bug: webrtc:13446 Change-Id: Ice9c418435bc7958562eb73524d7651a79508ab6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241440 Reviewed-by: Harald Alvestrand Reviewed-by: Henrik Boström Commit-Queue: Henrik Boström Cr-Commit-Position: refs/heads/main@{#35541} --- api/peer_connection_interface.h | 8 -------- pc/peer_connection.cc | 2 -- 2 files changed, 10 deletions(-) diff --git a/api/peer_connection_interface.h b/api/peer_connection_interface.h index 6d42b848b6..7a2ac12e41 100644 --- a/api/peer_connection_interface.h +++ b/api/peer_connection_interface.h @@ -1295,14 +1295,6 @@ class PeerConnectionObserver { // A new ICE candidate has been gathered. virtual void OnIceCandidate(const IceCandidateInterface* candidate) = 0; - // Gathering of an ICE candidate failed. - // See https://w3c.github.io/webrtc-pc/#event-icecandidateerror - // `host_candidate` is a stringified socket address. - virtual void OnIceCandidateError(const std::string& host_candidate, - const std::string& url, - int error_code, - const std::string& error_text) {} - // Gathering of an ICE candidate failed. // See https://w3c.github.io/webrtc-pc/#event-icecandidateerror virtual void OnIceCandidateError(const std::string& address, diff --git a/pc/peer_connection.cc b/pc/peer_connection.cc index 885f5573d5..94a00d2327 100644 --- a/pc/peer_connection.cc +++ b/pc/peer_connection.cc @@ -1938,8 +1938,6 @@ void PeerConnection::OnIceCandidateError(const std::string& address, return; } Observer()->OnIceCandidateError(address, port, url, error_code, error_text); - // Leftover not to break wpt test during migration to the new API. - Observer()->OnIceCandidateError(address + ":", url, error_code, error_text); } void PeerConnection::OnIceCandidatesRemoved(