admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make SSLStreamAdapter::SetPeerCertificateDigest use of const uint8_t

Browse Source 
This allows it to accept rtc::CopyOnWriteBuffer.

Bug: webrtc:357776213
Change-Id: I8c9eeb5577e8de902db144aff5ad8eee87e5a530
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/369640
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43464}
This commit is contained in:
Florent Castelli 2024-11-27 12:28:57 +00:00 committed by WebRTC LUCI CQ
parent 4a6a7465d0
commit 1bda6a6a58
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rtc_base/openssl_stream_adapter.cc
View File

@ -272,7 +272,7 @@ void OpenSSLStreamAdapter::SetServerRole(SSLRole role) {
SSLPeerCertificateDigestError OpenSSLStreamAdapter::SetPeerCertificateDigest(
absl::string_view digest_alg,
rtc::ArrayView<uint8_t> digest_val) {
rtc::ArrayView<const uint8_t> digest_val) {
RTC_DCHECK(!peer_certificate_verified_);
RTC_DCHECK(!HasPeerCertificateDigest());
size_t expected_len;

2
rtc_base/openssl_stream_adapter.h
View File

@ -80,7 +80,7 @@ class OpenSSLStreamAdapter final : public SSLStreamAdapter {
void SetServerRole(SSLRole role = SSL_SERVER) override;
SSLPeerCertificateDigestError SetPeerCertificateDigest(
absl::string_view digest_alg,
rtc::ArrayView<uint8_t> digest_val) override;
rtc::ArrayView<const uint8_t> digest_val) override;
std::unique_ptr<SSLCertChain> GetPeerSSLCertChain() const override;

2
rtc_base/ssl_stream_adapter.h
View File

@ -175,7 +175,7 @@ class SSLStreamAdapter : public StreamInterface {
// Returns SSLPeerCertificateDigestError::NONE if successful.
virtual SSLPeerCertificateDigestError SetPeerCertificateDigest(
absl::string_view digest_alg,
rtc::ArrayView<uint8_t> digest_val) = 0;
rtc::ArrayView<const uint8_t> digest_val) = 0;
[[deprecated(
"Use SetPeerCertificateDigest with ArrayView instead")]] virtual bool
SetPeerCertificateDigest(absl::string_view digest_alg,