From 1bda6a6a58abd4e98d91f714811a490bc2b03e66 Mon Sep 17 00:00:00 2001 From: Florent Castelli Date: Wed, 27 Nov 2024 12:28:57 +0000 Subject: [PATCH] Make SSLStreamAdapter::SetPeerCertificateDigest use of const uint8_t This allows it to accept rtc::CopyOnWriteBuffer. Bug: webrtc:357776213 Change-Id: I8c9eeb5577e8de902db144aff5ad8eee87e5a530 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/369640 Commit-Queue: Florent Castelli Reviewed-by: Harald Alvestrand Cr-Commit-Position: refs/heads/main@{#43464} --- rtc_base/openssl_stream_adapter.cc | 2 +- rtc_base/openssl_stream_adapter.h | 2 +- rtc_base/ssl_stream_adapter.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rtc_base/openssl_stream_adapter.cc b/rtc_base/openssl_stream_adapter.cc index 88e09166b0..7a6284790f 100644 --- a/rtc_base/openssl_stream_adapter.cc +++ b/rtc_base/openssl_stream_adapter.cc @@ -272,7 +272,7 @@ void OpenSSLStreamAdapter::SetServerRole(SSLRole role) { SSLPeerCertificateDigestError OpenSSLStreamAdapter::SetPeerCertificateDigest( absl::string_view digest_alg, - rtc::ArrayView digest_val) { + rtc::ArrayView digest_val) { RTC_DCHECK(!peer_certificate_verified_); RTC_DCHECK(!HasPeerCertificateDigest()); size_t expected_len; diff --git a/rtc_base/openssl_stream_adapter.h b/rtc_base/openssl_stream_adapter.h index 2ae7c0dd4e..82e0b1b632 100644 --- a/rtc_base/openssl_stream_adapter.h +++ b/rtc_base/openssl_stream_adapter.h @@ -80,7 +80,7 @@ class OpenSSLStreamAdapter final : public SSLStreamAdapter { void SetServerRole(SSLRole role = SSL_SERVER) override; SSLPeerCertificateDigestError SetPeerCertificateDigest( absl::string_view digest_alg, - rtc::ArrayView digest_val) override; + rtc::ArrayView digest_val) override; std::unique_ptr GetPeerSSLCertChain() const override; diff --git a/rtc_base/ssl_stream_adapter.h b/rtc_base/ssl_stream_adapter.h index 49094b8965..66617e31fb 100644 --- a/rtc_base/ssl_stream_adapter.h +++ b/rtc_base/ssl_stream_adapter.h @@ -175,7 +175,7 @@ class SSLStreamAdapter : public StreamInterface { // Returns SSLPeerCertificateDigestError::NONE if successful. virtual SSLPeerCertificateDigestError SetPeerCertificateDigest( absl::string_view digest_alg, - rtc::ArrayView digest_val) = 0; + rtc::ArrayView digest_val) = 0; [[deprecated( "Use SetPeerCertificateDigest with ArrayView instead")]] virtual bool SetPeerCertificateDigest(absl::string_view digest_alg,