admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove legacy implementation of AudioEncoderFactory::MakeAudioEncoder in a pc test

Browse Source 
All calls in code under test were migrated to AudioEncoderFactory::Create and thus there is no longer need to propagate older function.

Bug: webrtc:343086059
Change-Id: I9e0ea4024759deb22c0d284e0e4bac7322a08f62
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357181
Commit-Queue: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Florent Castelli <orphis@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42638}
This commit is contained in:
Danil Chapovalov 2024-07-15 11:25:54 +02:00 committed by WebRTC LUCI CQ
parent ea615affcc
commit 1bb68532dd
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pc/peer_connection_end_to_end_unittest.cc
View File

@ -420,14 +420,6 @@ TEST_P(PeerConnectionEndToEndTest, CallWithCustomCodec) {
const webrtc::SdpAudioFormat& format) override {
return fact_->QueryAudioEncoder(format);
}
std::unique_ptr<webrtc::AudioEncoder> MakeAudioEncoder(
int payload_type,
const webrtc::SdpAudioFormat& format,
absl::optional<webrtc::AudioCodecPairId> codec_pair_id) override {
EXPECT_TRUE(codec_pair_id.has_value());
codec_ids_->push_back(*codec_pair_id);
return fact_->MakeAudioEncoder(payload_type, format, codec_pair_id);
}
std::unique_ptr<webrtc::AudioEncoder> Create(
const Environment& env,
const webrtc::SdpAudioFormat& format,