From 1bb68532dd38e88c87dd29c27e7a9c7c19370ba3 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Mon, 15 Jul 2024 11:25:54 +0200 Subject: [PATCH] Remove legacy implementation of AudioEncoderFactory::MakeAudioEncoder in a pc test All calls in code under test were migrated to AudioEncoderFactory::Create and thus there is no longer need to propagate older function. Bug: webrtc:343086059 Change-Id: I9e0ea4024759deb22c0d284e0e4bac7322a08f62 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/357181 Commit-Queue: Danil Chapovalov Reviewed-by: Florent Castelli Cr-Commit-Position: refs/heads/main@{#42638} --- pc/peer_connection_end_to_end_unittest.cc | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pc/peer_connection_end_to_end_unittest.cc b/pc/peer_connection_end_to_end_unittest.cc index 516a01edce..3edfb1b650 100644 --- a/pc/peer_connection_end_to_end_unittest.cc +++ b/pc/peer_connection_end_to_end_unittest.cc @@ -420,14 +420,6 @@ TEST_P(PeerConnectionEndToEndTest, CallWithCustomCodec) { const webrtc::SdpAudioFormat& format) override { return fact_->QueryAudioEncoder(format); } - std::unique_ptr MakeAudioEncoder( - int payload_type, - const webrtc::SdpAudioFormat& format, - absl::optional codec_pair_id) override { - EXPECT_TRUE(codec_pair_id.has_value()); - codec_ids_->push_back(*codec_pair_id); - return fact_->MakeAudioEncoder(payload_type, format, codec_pair_id); - } std::unique_ptr Create( const Environment& env, const webrtc::SdpAudioFormat& format,