admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable VideoReceiveStreamTestWithFakeDecoder.RenderedFrameUpdatesGetSources for iOS.

Browse Source 
This change re-enables a previously flaky unit tests for iOS. It seems to have the same root cause as webrtc:10827 and which was fixed by: https://webrtc-review.googlesource.com/c/src/+/149171

Bug: webrtc:10872, webrtc:10827
Change-Id: I71b2581cf8c75e0dd6a39b77e6cf34c121ff22f4
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149802
Reviewed-by: Niels Moller <nisse@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
Commit-Queue: Chen Xing <chxg@google.com>
Cr-Commit-Position: refs/heads/master@{#28893}
This commit is contained in:
Chen Xing 2019-08-19 11:16:08 +02:00 committed by Commit Bot
parent 77acb015b6
commit 17f9ee5358
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
video/video_receive_stream_unittest.cc
View File

@ -313,13 +313,7 @@ TEST_F(VideoReceiveStreamTestWithFakeDecoder, PassesPacketInfos) {
EXPECT_THAT(fake_renderer_.packet_infos(), ElementsAreArray(packet_infos)); EXPECT_THAT(fake_renderer_.packet_infos(), ElementsAreArray(packet_infos));
} }
// TODO(crbug.com/webrtc/10872): Re-enable on iOS
#if defined(WEBRTC_IOS)
TEST_F(VideoReceiveStreamTestWithFakeDecoder,
DISABLED_RenderedFrameUpdatesGetSources) {
#else
TEST_F(VideoReceiveStreamTestWithFakeDecoder, RenderedFrameUpdatesGetSources) { TEST_F(VideoReceiveStreamTestWithFakeDecoder, RenderedFrameUpdatesGetSources) {
#endif
constexpr uint32_t kSsrc = 1111; constexpr uint32_t kSsrc = 1111;
constexpr uint32_t kCsrc = 9001; constexpr uint32_t kCsrc = 9001;
constexpr uint32_t kRtpTimestamp = 12345; constexpr uint32_t kRtpTimestamp = 12345;