From 17f9ee5358274ff79e6cfafa64c6ed3a073335d9 Mon Sep 17 00:00:00 2001 From: Chen Xing Date: Mon, 19 Aug 2019 11:16:08 +0200 Subject: [PATCH] Enable `VideoReceiveStreamTestWithFakeDecoder.RenderedFrameUpdatesGetSources` for iOS. This change re-enables a previously flaky unit tests for iOS. It seems to have the same root cause as webrtc:10827 and which was fixed by: https://webrtc-review.googlesource.com/c/src/+/149171 Bug: webrtc:10872, webrtc:10827 Change-Id: I71b2581cf8c75e0dd6a39b77e6cf34c121ff22f4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149802 Reviewed-by: Niels Moller Reviewed-by: Ilya Nikolaevskiy Reviewed-by: Jonas Oreland Commit-Queue: Chen Xing Cr-Commit-Position: refs/heads/master@{#28893} --- video/video_receive_stream_unittest.cc | 6 ------ 1 file changed, 6 deletions(-) diff --git a/video/video_receive_stream_unittest.cc b/video/video_receive_stream_unittest.cc index 2f9564e239..6d88f67e92 100644 --- a/video/video_receive_stream_unittest.cc +++ b/video/video_receive_stream_unittest.cc @@ -313,13 +313,7 @@ TEST_F(VideoReceiveStreamTestWithFakeDecoder, PassesPacketInfos) { EXPECT_THAT(fake_renderer_.packet_infos(), ElementsAreArray(packet_infos)); } -// TODO(crbug.com/webrtc/10872): Re-enable on iOS -#if defined(WEBRTC_IOS) -TEST_F(VideoReceiveStreamTestWithFakeDecoder, - DISABLED_RenderedFrameUpdatesGetSources) { -#else TEST_F(VideoReceiveStreamTestWithFakeDecoder, RenderedFrameUpdatesGetSources) { -#endif constexpr uint32_t kSsrc = 1111; constexpr uint32_t kCsrc = 9001; constexpr uint32_t kRtpTimestamp = 12345;