admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Window Capture] Inaccurate cursor position during window sharing on X11

Browse Source 
{root_x, root_y} should be used to report the absolute cursor position in
MouseCursorMonitorX11.

Bug: chromium:778035
Change-Id: I421005d52786a57da8e8c3901bdf4afa2843ff24
Reviewed-on: https://webrtc-review.googlesource.com/15680
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Zijie He <zijiehe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20432}
This commit is contained in:
Zijie He 2017-10-25 12:04:41 -07:00 committed by Commit Bot
parent 84634b8634
commit 173fd91b56
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
modules/desktop_capture/mouse_cursor_monitor_x11.cc
View File

@ -201,12 +201,11 @@ void MouseCursorMonitorX11::Capture() {
}
}
const DesktopVector position(win_x, win_y);
// TODO(zijiehe): Remove this overload.
callback_->OnMouseCursorPosition(state, position);
callback_->OnMouseCursorPosition(state, DesktopVector(win_x, win_y));
// X11 always starts the coordinate from (0, 0), so we do not need to
// translate here.
callback_->OnMouseCursorPosition(position);
callback_->OnMouseCursorPosition(DesktopVector(root_x, root_y));
}
}