From 173fd91b56f5655890e8a6502f909d217e3a9c03 Mon Sep 17 00:00:00 2001 From: Zijie He Date: Wed, 25 Oct 2017 12:04:41 -0700 Subject: [PATCH] [Window Capture] Inaccurate cursor position during window sharing on X11 {root_x, root_y} should be used to report the absolute cursor position in MouseCursorMonitorX11. Bug: chromium:778035 Change-Id: I421005d52786a57da8e8c3901bdf4afa2843ff24 Reviewed-on: https://webrtc-review.googlesource.com/15680 Reviewed-by: Jamie Walch Commit-Queue: Zijie He Cr-Commit-Position: refs/heads/master@{#20432} --- modules/desktop_capture/mouse_cursor_monitor_x11.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/modules/desktop_capture/mouse_cursor_monitor_x11.cc b/modules/desktop_capture/mouse_cursor_monitor_x11.cc index b2700d3fe2..84356278f3 100644 --- a/modules/desktop_capture/mouse_cursor_monitor_x11.cc +++ b/modules/desktop_capture/mouse_cursor_monitor_x11.cc @@ -201,12 +201,11 @@ void MouseCursorMonitorX11::Capture() { } } - const DesktopVector position(win_x, win_y); // TODO(zijiehe): Remove this overload. - callback_->OnMouseCursorPosition(state, position); + callback_->OnMouseCursorPosition(state, DesktopVector(win_x, win_y)); // X11 always starts the coordinate from (0, 0), so we do not need to // translate here. - callback_->OnMouseCursorPosition(position); + callback_->OnMouseCursorPosition(DesktopVector(root_x, root_y)); } }