admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing test deps in webrtc/test/fuzzers

Browse Source 
Targets in webrtc/test/fuzzers are used in chromium which includes WebRTC
with rtc_include_tests=false.

We enabled 'gn check' on the webrtc/test directory and we have detected
that some dependencies were not tracked. These dependencies are on test
targets so we cannot add them in the dep list because this causes a
breakage in chromium.

BUG=webrtc:7515
NOTRY=True

Review-Url: https://codereview.webrtc.org/2840523003
Cr-Commit-Position: refs/heads/master@{#17844}
This commit is contained in:
mbonadei 2017-04-24 08:44:14 -07:00 committed by Commit bot
parent 70c09bde41
commit 14b86d3864
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
webrtc/test/fuzzers/BUILD.gn
View File

@ -112,13 +112,18 @@ webrtc_fuzzer_test("ulpfec_header_reader_fuzzer") {
}
webrtc_fuzzer_test("ulpfec_generator_fuzzer") {
check_includes = false # TODO(mbonadei): see bugs.webrtc.org/7515
sources = [
"ulpfec_generator_fuzzer.cc",
]
deps = [
# Removing rtp_rtcp_unittests from the dep list because it causes problems
# in chromium (chromium has rtc_include_tests set to false so these targets
# does not exist).
"../../base:rtc_base_approved",
"../../modules/rtp_rtcp",
"../../modules/rtp_rtcp:rtp_rtcp_unittests",
# "../../modules/rtp_rtcp:rtp_rtcp_unittests",
]
}
@ -271,15 +276,21 @@ webrtc_fuzzer_test("turn_unwrap_fuzzer") {
}
webrtc_fuzzer_test("neteq_rtp_fuzzer") {
check_includes = false # TODO(mbonadei): see bugs.webrtc.org/7515
sources = [
"neteq_rtp_fuzzer.cc",
]
deps = [
# Removing rtc_base_tests_utils and neteq_unittest_tools from the dep list
# because they cause problems in chromium (chromium has rtc_include_tests
# set to false so these targets does not exist).
"../../base:rtc_base_approved",
"../../base:rtc_base_tests_utils",
# "../../base:rtc_base_tests_utils",
"../../modules/audio_coding:neteq",
"../../modules/audio_coding:neteq_test_minimal",
"../../modules/audio_coding:neteq_unittest_tools",
# "../../modules/audio_coding:neteq_unittest_tools",
"../../modules/audio_coding:pcm16b",
"../../modules/rtp_rtcp",
]