From 14b86d386460a759da1d5029cc09eda46330ea2b Mon Sep 17 00:00:00 2001 From: mbonadei Date: Mon, 24 Apr 2017 08:44:14 -0700 Subject: [PATCH] Removing test deps in webrtc/test/fuzzers Targets in webrtc/test/fuzzers are used in chromium which includes WebRTC with rtc_include_tests=false. We enabled 'gn check' on the webrtc/test directory and we have detected that some dependencies were not tracked. These dependencies are on test targets so we cannot add them in the dep list because this causes a breakage in chromium. BUG=webrtc:7515 NOTRY=True Review-Url: https://codereview.webrtc.org/2840523003 Cr-Commit-Position: refs/heads/master@{#17844} --- webrtc/test/fuzzers/BUILD.gn | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/webrtc/test/fuzzers/BUILD.gn b/webrtc/test/fuzzers/BUILD.gn index c184452f45..cab2483731 100644 --- a/webrtc/test/fuzzers/BUILD.gn +++ b/webrtc/test/fuzzers/BUILD.gn @@ -112,13 +112,18 @@ webrtc_fuzzer_test("ulpfec_header_reader_fuzzer") { } webrtc_fuzzer_test("ulpfec_generator_fuzzer") { + check_includes = false # TODO(mbonadei): see bugs.webrtc.org/7515 sources = [ "ulpfec_generator_fuzzer.cc", ] deps = [ + # Removing rtp_rtcp_unittests from the dep list because it causes problems + # in chromium (chromium has rtc_include_tests set to false so these targets + # does not exist). "../../base:rtc_base_approved", "../../modules/rtp_rtcp", - "../../modules/rtp_rtcp:rtp_rtcp_unittests", + + # "../../modules/rtp_rtcp:rtp_rtcp_unittests", ] } @@ -271,15 +276,21 @@ webrtc_fuzzer_test("turn_unwrap_fuzzer") { } webrtc_fuzzer_test("neteq_rtp_fuzzer") { + check_includes = false # TODO(mbonadei): see bugs.webrtc.org/7515 sources = [ "neteq_rtp_fuzzer.cc", ] deps = [ + # Removing rtc_base_tests_utils and neteq_unittest_tools from the dep list + # because they cause problems in chromium (chromium has rtc_include_tests + # set to false so these targets does not exist). "../../base:rtc_base_approved", - "../../base:rtc_base_tests_utils", + + # "../../base:rtc_base_tests_utils", "../../modules/audio_coding:neteq", "../../modules/audio_coding:neteq_test_minimal", - "../../modules/audio_coding:neteq_unittest_tools", + + # "../../modules/audio_coding:neteq_unittest_tools", "../../modules/audio_coding:pcm16b", "../../modules/rtp_rtcp", ]