admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix PeerConnectionDependencies leak on PC init.

Browse Source 
Release + dereference operator does not magically move buffer from
heap to stack, so there was a leak.

Bug: None
Change-Id: I9f760b6719ca1fc03aa3efcfda0c0ff9d87efda8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/308581
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com>
Cr-Commit-Position: refs/heads/main@{#40303}
This commit is contained in:
Yury Yarashevich 2023-06-13 12:27:30 +02:00 committed by WebRTC LUCI CQ
parent 4d2a219436
commit 11affddbbc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/objc/api/peerconnection/RTCPeerConnection.mm
View File

@ -371,7 +371,7 @@ void PeerConnectionDelegateAdapter::OnRemoveTrack(
_nativeConstraints = constraints.nativeConstraints;
CopyConstraintsIntoRtcConfiguration(_nativeConstraints.get(), config.get());
webrtc::PeerConnectionDependencies deps = std::move(*dependencies.release());
webrtc::PeerConnectionDependencies deps = std::move(*dependencies);
deps.observer = _observer.get();
auto result = factory.nativeFactory->CreatePeerConnectionOrError(*config, std::move(deps));