From 11affddbbc7e976abbf10afa9468fa4026316627 Mon Sep 17 00:00:00 2001 From: Yury Yarashevich Date: Tue, 13 Jun 2023 12:27:30 +0200 Subject: [PATCH] Fix PeerConnectionDependencies leak on PC init. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Release + dereference operator does not magically move buffer from heap to stack, so there was a leak. Bug: None Change-Id: I9f760b6719ca1fc03aa3efcfda0c0ff9d87efda8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/308581 Reviewed-by: Kári Helgason Commit-Queue: Yury Yarashevich Cr-Commit-Position: refs/heads/main@{#40303} --- sdk/objc/api/peerconnection/RTCPeerConnection.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/objc/api/peerconnection/RTCPeerConnection.mm b/sdk/objc/api/peerconnection/RTCPeerConnection.mm index df99030111..3f187c05b9 100644 --- a/sdk/objc/api/peerconnection/RTCPeerConnection.mm +++ b/sdk/objc/api/peerconnection/RTCPeerConnection.mm @@ -371,7 +371,7 @@ void PeerConnectionDelegateAdapter::OnRemoveTrack( _nativeConstraints = constraints.nativeConstraints; CopyConstraintsIntoRtcConfiguration(_nativeConstraints.get(), config.get()); - webrtc::PeerConnectionDependencies deps = std::move(*dependencies.release()); + webrtc::PeerConnectionDependencies deps = std::move(*dependencies); deps.observer = _observer.get(); auto result = factory.nativeFactory->CreatePeerConnectionOrError(*config, std::move(deps));