admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Relax expectation in EndToEndTest.CallReportsRttForSender test

Browse Source 
to reduce flakiness by ignoring potentional rounding errors
and minor ntp time adjustments.

BUG=webrtc:5938
R=deadbeef@webrtc.org, stefan@webrtc.org

Review URL: https://codereview.webrtc.org/2277633004 .

Cr-Commit-Position: refs/heads/master@{#14104}
This commit is contained in:
Danil Chapovalov 2016-09-07 15:05:29 +02:00
parent 2d273f1e97
commit 10e8f8e2a4
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/video/end_to_end_tests.cc
View File

@ -3507,7 +3507,10 @@ TEST_F(EndToEndTest, CallReportsRttForSender) {
clock_->TimeInMilliseconds())
<< "No RTT stats before timeout!";
if (stats.rtt_ms != -1) {
EXPECT_GE(stats.rtt_ms, kSendDelayMs + kReceiveDelayMs);
// To avoid failures caused by rounding or minor ntp clock adjustments,
// relax expectation by 1ms.
constexpr int kAllowedErrorMs = 1;
EXPECT_GE(stats.rtt_ms, kSendDelayMs + kReceiveDelayMs - kAllowedErrorMs);
break;
}
SleepMs(10);