From 10e8f8e2a4e17a24f4b17e38b7e6c87e879e1b96 Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Wed, 7 Sep 2016 15:05:29 +0200 Subject: [PATCH] Relax expectation in EndToEndTest.CallReportsRttForSender test to reduce flakiness by ignoring potentional rounding errors and minor ntp time adjustments. BUG=webrtc:5938 R=deadbeef@webrtc.org, stefan@webrtc.org Review URL: https://codereview.webrtc.org/2277633004 . Cr-Commit-Position: refs/heads/master@{#14104} --- webrtc/video/end_to_end_tests.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc index 281e225bd8..55d5cc073d 100644 --- a/webrtc/video/end_to_end_tests.cc +++ b/webrtc/video/end_to_end_tests.cc @@ -3507,7 +3507,10 @@ TEST_F(EndToEndTest, CallReportsRttForSender) { clock_->TimeInMilliseconds()) << "No RTT stats before timeout!"; if (stats.rtt_ms != -1) { - EXPECT_GE(stats.rtt_ms, kSendDelayMs + kReceiveDelayMs); + // To avoid failures caused by rounding or minor ntp clock adjustments, + // relax expectation by 1ms. + constexpr int kAllowedErrorMs = 1; + EXPECT_GE(stats.rtt_ms, kSendDelayMs + kReceiveDelayMs - kAllowedErrorMs); break; } SleepMs(10);