admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable PhysicalSocketTest.TestUdpReadyToSendIPv4 on Android.

Browse Source 
The test didn't previously run on Android bots, but was enabled by
mistake in https://codereview.webrtc.org/1426643003/

It used to be long to the rtc_unittests target, which also don't run
on Android unfortunately. For now, let's just disable this one test
on Android to get the bots go green.

BUG=4364
TBR=pthatcher@webrtc.org

Review URL: https://codereview.webrtc.org/1419033007 .

Cr-Commit-Position: refs/heads/master@{#10464}
This commit is contained in:
Henrik Kjellander 2015-10-30 21:21:03 +01:00
parent 8a4f547dad
commit 0be3e040f6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc/base/physicalsocketserver_unittest.cc
View File

@ -215,8 +215,9 @@ TEST_F(PhysicalSocketTest, MAYBE_TestUdpIPv6) {
// https://code.google.com/p/webrtc/issues/detail?id=4958
// TODO(deadbeef): Enable again once test is reimplemented to be unflaky.
// Also disable for ASan.
// Disabled on Android: https://code.google.com/p/webrtc/issues/detail?id=4364
#if defined(THREAD_SANITIZER) || defined(MEMORY_SANITIZER) || \
defined(ADDRESS_SANITIZER)
defined(ADDRESS_SANITIZER) || defined(WEBRTC_ANDROID)
#define MAYBE_TestUdpReadyToSendIPv4 DISABLED_TestUdpReadyToSendIPv4
#else
#define MAYBE_TestUdpReadyToSendIPv4 TestUdpReadyToSendIPv4