admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Hang on android when DNS resolution is not done

Browse Source 
BUG=webrtc:5139
R=juberti@google.com
TBR=juberti@webrtc.org

Review URL: https://codereview.webrtc.org/1429493009 .

Cr-Commit-Position: refs/heads/master@{#10463}
This commit is contained in:
Guo-wei Shieh 2015-10-30 09:12:34 -07:00
parent 534dafcc08
commit 8a4f547dad
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/p2p/base/stunport.cc
View File

@ -116,7 +116,10 @@ UDPPort::AddressResolver::AddressResolver(
UDPPort::AddressResolver::~AddressResolver() {
for (ResolverMap::iterator it = resolvers_.begin();
it != resolvers_.end(); ++it) {
it->second->Destroy(true);
// TODO(guoweis): Change to asynchronous DNS resolution to prevent the hang
// when passing true to the Destroy() which is a safer way to avoid the code
// unloaded before the thread exits. Please see webrtc bug 5139.
it->second->Destroy(false);
}
}