admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure both corruption detection tests are formulated the same way

Browse Source 
DoesNotPopulateFrameInstrumentationDataWhenSetNotTo should be formulated equivalently to PopulatesFrameInstrumentationDataWhenSetTo.

Bug: webrtc:358039777
Change-Id: I22d487d0a88cd3e1badb3bb8bf304a0322f9d53e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363862
Commit-Queue: Fanny Linderborg <linderborg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43090}
This commit is contained in:
Fanny Linderborg 2024-09-26 13:46:40 +02:00 committed by WebRTC LUCI CQ
parent a61a25a0b1
commit 0a3a6908e8
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
video/video_stream_encoder_unittest.cc
View File

@ -1713,13 +1713,12 @@ TEST_F(VideoStreamEncoderTest,
// We need a QP for the encoded frame.
fake_encoder_.SetEncodedImageData(EncodedImageBuffer::Create(
kCodedFrameVp8Qp25, sizeof(kCodedFrameVp8Qp25)));
rtc::Event frame_destroyed_event;
video_source_.IncomingCapturedFrame(CreateFrame(1, &frame_destroyed_event));
video_source_.IncomingCapturedFrame(
CreateFrame(1, codec_width_, codec_height_));
WaitForEncodedFrame(1);
EXPECT_FALSE(sink_.GetLastFrameInstrumentationData().has_value());
video_stream_encoder_->Stop();
EXPECT_TRUE(frame_destroyed_event.Wait(kDefaultTimeout));
}
TEST_F(VideoStreamEncoderTest, DropsFramesBeforeFirstOnBitrateUpdated) {