From 0a3a6908e820dbb002edfe97f176833e15217079 Mon Sep 17 00:00:00 2001 From: Fanny Linderborg Date: Thu, 26 Sep 2024 13:46:40 +0200 Subject: [PATCH] Ensure both corruption detection tests are formulated the same way MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DoesNotPopulateFrameInstrumentationDataWhenSetNotTo should be formulated equivalently to PopulatesFrameInstrumentationDataWhenSetTo. Bug: webrtc:358039777 Change-Id: I22d487d0a88cd3e1badb3bb8bf304a0322f9d53e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/363862 Commit-Queue: Fanny Linderborg Reviewed-by: Erik Språng Cr-Commit-Position: refs/heads/main@{#43090} --- video/video_stream_encoder_unittest.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/video/video_stream_encoder_unittest.cc b/video/video_stream_encoder_unittest.cc index 5fe7373351..b93a1255da 100644 --- a/video/video_stream_encoder_unittest.cc +++ b/video/video_stream_encoder_unittest.cc @@ -1713,13 +1713,12 @@ TEST_F(VideoStreamEncoderTest, // We need a QP for the encoded frame. fake_encoder_.SetEncodedImageData(EncodedImageBuffer::Create( kCodedFrameVp8Qp25, sizeof(kCodedFrameVp8Qp25))); - rtc::Event frame_destroyed_event; - video_source_.IncomingCapturedFrame(CreateFrame(1, &frame_destroyed_event)); + video_source_.IncomingCapturedFrame( + CreateFrame(1, codec_width_, codec_height_)); WaitForEncodedFrame(1); EXPECT_FALSE(sink_.GetLastFrameInstrumentationData().has_value()); video_stream_encoder_->Stop(); - EXPECT_TRUE(frame_destroyed_event.Wait(kDefaultTimeout)); } TEST_F(VideoStreamEncoderTest, DropsFramesBeforeFirstOnBitrateUpdated) {