As documented in webrtc:11908 this cleanup is fairly invasive and when a part of a frequently executed code path, can be quite costly in terms of performance overhead. This is currently the case with synchronous calls between threads (Thread) as well with our proxy api classes. With this CL, all code in WebRTC should now either be using MessageHandlerAutoCleanup or calling MessageHandler(false) explicitly. Next steps will be to update external code to either depend on the AutoCleanup variant, or call MessageHandler(false). Changing the proxy classes to use TaskQueue set of concepts instead of MessageHandler. This avoids the perf overhead related to the cleanup above as well as incompatibility with the thread policy checks in Thread that some current external users of the proxies would otherwise run into (if we were to use Thread::Send() for synchronous call). Following this we'll move the cleanup step into the AutoCleanup class and an RTC_DCHECK that all calls to the MessageHandler are setting the flag to false, before eventually removing the flag and make MessageHandler pure virtual. Bug: webrtc:11908 Change-Id: Idf4ff9bcc8438cb8c583777e282005e0bc511c8f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183442 Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Tommi <tommi@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32049}
138 lines
4.1 KiB
C++
138 lines
4.1 KiB
C++
/*
|
|
* Copyright 2009 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef RTC_BASE_FAKE_NETWORK_H_
|
|
#define RTC_BASE_FAKE_NETWORK_H_
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "absl/memory/memory.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/mdns_responder_interface.h"
|
|
#include "rtc_base/message_handler.h"
|
|
#include "rtc_base/network.h"
|
|
#include "rtc_base/socket_address.h"
|
|
#include "rtc_base/string_encode.h"
|
|
#include "rtc_base/thread.h"
|
|
|
|
namespace rtc {
|
|
|
|
const int kFakeIPv4NetworkPrefixLength = 24;
|
|
const int kFakeIPv6NetworkPrefixLength = 64;
|
|
|
|
// Fake network manager that allows us to manually specify the IPs to use.
|
|
class FakeNetworkManager : public NetworkManagerBase,
|
|
public MessageHandlerAutoCleanup {
|
|
public:
|
|
FakeNetworkManager() {}
|
|
|
|
typedef std::vector<std::pair<SocketAddress, AdapterType>> IfaceList;
|
|
|
|
void AddInterface(const SocketAddress& iface) {
|
|
// Ensure a unique name for the interface if its name is not given.
|
|
AddInterface(iface, "test" + rtc::ToString(next_index_++));
|
|
}
|
|
|
|
void AddInterface(const SocketAddress& iface, const std::string& if_name) {
|
|
AddInterface(iface, if_name, ADAPTER_TYPE_UNKNOWN);
|
|
}
|
|
|
|
void AddInterface(const SocketAddress& iface,
|
|
const std::string& if_name,
|
|
AdapterType type) {
|
|
SocketAddress address(if_name, 0);
|
|
address.SetResolvedIP(iface.ipaddr());
|
|
ifaces_.push_back(std::make_pair(address, type));
|
|
DoUpdateNetworks();
|
|
}
|
|
|
|
void RemoveInterface(const SocketAddress& iface) {
|
|
for (IfaceList::iterator it = ifaces_.begin(); it != ifaces_.end(); ++it) {
|
|
if (it->first.EqualIPs(iface)) {
|
|
ifaces_.erase(it);
|
|
break;
|
|
}
|
|
}
|
|
DoUpdateNetworks();
|
|
}
|
|
|
|
void StartUpdating() override {
|
|
++start_count_;
|
|
if (start_count_ == 1) {
|
|
sent_first_update_ = false;
|
|
rtc::Thread::Current()->Post(RTC_FROM_HERE, this);
|
|
} else {
|
|
if (sent_first_update_) {
|
|
SignalNetworksChanged();
|
|
}
|
|
}
|
|
}
|
|
|
|
void StopUpdating() override { --start_count_; }
|
|
|
|
// MessageHandler interface.
|
|
void OnMessage(Message* msg) override { DoUpdateNetworks(); }
|
|
|
|
using NetworkManagerBase::set_default_local_addresses;
|
|
using NetworkManagerBase::set_enumeration_permission;
|
|
|
|
// rtc::NetworkManager override.
|
|
webrtc::MdnsResponderInterface* GetMdnsResponder() const override {
|
|
return mdns_responder_.get();
|
|
}
|
|
|
|
void set_mdns_responder(
|
|
std::unique_ptr<webrtc::MdnsResponderInterface> mdns_responder) {
|
|
mdns_responder_ = std::move(mdns_responder);
|
|
}
|
|
|
|
private:
|
|
void DoUpdateNetworks() {
|
|
if (start_count_ == 0)
|
|
return;
|
|
std::vector<Network*> networks;
|
|
for (IfaceList::iterator it = ifaces_.begin(); it != ifaces_.end(); ++it) {
|
|
int prefix_length = 0;
|
|
if (it->first.ipaddr().family() == AF_INET) {
|
|
prefix_length = kFakeIPv4NetworkPrefixLength;
|
|
} else if (it->first.ipaddr().family() == AF_INET6) {
|
|
prefix_length = kFakeIPv6NetworkPrefixLength;
|
|
}
|
|
IPAddress prefix = TruncateIP(it->first.ipaddr(), prefix_length);
|
|
std::unique_ptr<Network> net(new Network(it->first.hostname(),
|
|
it->first.hostname(), prefix,
|
|
prefix_length, it->second));
|
|
net->set_default_local_address_provider(this);
|
|
net->AddIP(it->first.ipaddr());
|
|
networks.push_back(net.release());
|
|
}
|
|
bool changed;
|
|
MergeNetworkList(networks, &changed);
|
|
if (changed || !sent_first_update_) {
|
|
SignalNetworksChanged();
|
|
sent_first_update_ = true;
|
|
}
|
|
}
|
|
|
|
IfaceList ifaces_;
|
|
int next_index_ = 0;
|
|
int start_count_ = 0;
|
|
bool sent_first_update_ = false;
|
|
|
|
std::unique_ptr<webrtc::MdnsResponderInterface> mdns_responder_;
|
|
};
|
|
|
|
} // namespace rtc
|
|
|
|
#endif // RTC_BASE_FAKE_NETWORK_H_
|