fe25b0e928
This CL fixes two issues with the old way targetBitrate was reported: 1. The target is per encoder, i.e. per SSRC, but the old way to report it was per sender and was approximately the sum of all encodings' targetBitrate in most cases. 2. The old value did not come directly from the VideoBitrateAllocation and tended to be greater than the sum of all targets (don't know why). We know the old value was wrong and the new value correct because the actual bytes produced by the encoder closely matches the configured target, which wasn't always the case with the old metric implementation. Tested with unit tests and manually in Chrome by going to https://henbos.github.io/codec-quality/src/index.html and ensuring target ~= actual bytes produced. It also matches the debug logging of video_stream_encoder.cc. Bug: webrtc:42225524, chromium:392424845 Change-Id: I7a6f69e053ebc3fd972c2c4b7712750e721c0acc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/376460 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43854}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs
- Documentation