This change refactors existing self-assignments within if clauses across the WebRTC codebase. *Why:* - Bug Prevention: Assignments within conditionals are frequently unintended errors, often mistaken for equality checks. - Clearer Code: Separating assignments from conditionals improves code readability and reduces the risk of misinterpretation. Change-Id: I199dc26a35ceca109a2ac569b446811314dfdf0b Bug: chromium:361594695 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/360460 Reviewed-by: Chuck Hays <haysc@webrtc.org> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42850}
67 lines
1.7 KiB
Objective-C
67 lines
1.7 KiB
Objective-C
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import "RTCVideoCodecInfo.h"
|
|
|
|
@implementation RTC_OBJC_TYPE (RTCVideoCodecInfo)
|
|
|
|
@synthesize name = _name;
|
|
@synthesize parameters = _parameters;
|
|
|
|
- (instancetype)initWithName:(NSString *)name {
|
|
return [self initWithName:name parameters:nil];
|
|
}
|
|
|
|
- (instancetype)initWithName:(NSString *)name
|
|
parameters:(nullable NSDictionary<NSString *, NSString *> *)parameters {
|
|
self = [super init];
|
|
if (self) {
|
|
_name = name;
|
|
_parameters = (parameters ? parameters : @{});
|
|
}
|
|
|
|
return self;
|
|
}
|
|
|
|
- (BOOL)isEqualToCodecInfo:(RTC_OBJC_TYPE(RTCVideoCodecInfo) *)info {
|
|
if (!info ||
|
|
![self.name isEqualToString:info.name] ||
|
|
![self.parameters isEqualToDictionary:info.parameters]) {
|
|
return NO;
|
|
}
|
|
return YES;
|
|
}
|
|
|
|
- (BOOL)isEqual:(id)object {
|
|
if (self == object)
|
|
return YES;
|
|
if (![object isKindOfClass:[self class]])
|
|
return NO;
|
|
return [self isEqualToCodecInfo:object];
|
|
}
|
|
|
|
- (NSUInteger)hash {
|
|
return [self.name hash] ^ [self.parameters hash];
|
|
}
|
|
|
|
#pragma mark - NSCoding
|
|
|
|
- (instancetype)initWithCoder:(NSCoder *)decoder {
|
|
return [self initWithName:[decoder decodeObjectForKey:@"name"]
|
|
parameters:[decoder decodeObjectForKey:@"parameters"]];
|
|
}
|
|
|
|
- (void)encodeWithCoder:(NSCoder *)encoder {
|
|
[encoder encodeObject:_name forKey:@"name"];
|
|
[encoder encodeObject:_parameters forKey:@"parameters"];
|
|
}
|
|
|
|
@end
|