Web Spec and C++ version of setCodecPreferences are failable, as they return an RTCError (in C++) or throw an InvalidModificationError (in Web Spec). However, current Objective-C version of setCodecPreferences is not failable, so callers cannot know if the operation succeeded or not. Also, the current Objective-C version does not accept nil, which is not spec-compliant. (Web Spec says if codecs is an empty list, set transceiver.PreferredCodecs to codecs and abort these steps.) Bug: webrtc:42226103, webrtc:42226230 Change-Id: Ib90f3e5b45fc959eeb92f623cf50efcb458a7478 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352400 Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Commit-Queue: Kári Helgason <kthelgason@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#42789}
67 lines
2.0 KiB
C
67 lines
2.0 KiB
C
/*
|
|
* Copyright 2016 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef SDK_OBJC_BASE_RTCMACROS_H_
|
|
#define SDK_OBJC_BASE_RTCMACROS_H_
|
|
|
|
#ifdef WEBRTC_ENABLE_OBJC_SYMBOL_EXPORT
|
|
|
|
#if defined(WEBRTC_LIBRARY_IMPL)
|
|
#define RTC_OBJC_EXPORT __attribute__((visibility("default")))
|
|
#endif
|
|
|
|
#endif // WEBRTC_ENABLE_OBJC_SYMBOL_EXPORT
|
|
|
|
#ifndef RTC_OBJC_EXPORT
|
|
#define RTC_OBJC_EXPORT
|
|
#endif
|
|
|
|
// Macro used to mark a function as deprecated.
|
|
#define RTC_OBJC_DEPRECATED(msg) __attribute__((deprecated(msg)))
|
|
|
|
// Internal macros used to correctly concatenate symbols.
|
|
#define RTC_SYMBOL_CONCAT_HELPER(a, b) a##b
|
|
#define RTC_SYMBOL_CONCAT(a, b) RTC_SYMBOL_CONCAT_HELPER(a, b)
|
|
|
|
// RTC_OBJC_TYPE_PREFIX
|
|
//
|
|
// Macro used to prepend a prefix to the API types that are exported with
|
|
// RTC_OBJC_EXPORT.
|
|
//
|
|
// Clients can patch the definition of this macro locally and build
|
|
// WebRTC.framework with their own prefix in case symbol clashing is a
|
|
// problem.
|
|
//
|
|
// This macro must be defined uniformily across all the translation units.
|
|
#ifndef RTC_OBJC_TYPE_PREFIX
|
|
#define RTC_OBJC_TYPE_PREFIX
|
|
#endif
|
|
|
|
// RCT_OBJC_TYPE
|
|
//
|
|
// Macro used internally to declare API types. Declaring an API type without
|
|
// using this macro will not include the declared type in the set of types
|
|
// that will be affected by the configurable RTC_OBJC_TYPE_PREFIX.
|
|
#define RTC_OBJC_TYPE(type_name) RTC_SYMBOL_CONCAT(RTC_OBJC_TYPE_PREFIX, type_name)
|
|
|
|
#if defined(__cplusplus)
|
|
#define RTC_EXTERN extern "C" RTC_OBJC_EXPORT
|
|
#else
|
|
#define RTC_EXTERN extern RTC_OBJC_EXPORT
|
|
#endif
|
|
|
|
#ifdef __OBJC__
|
|
#define RTC_FWD_DECL_OBJC_CLASS(classname) @class classname
|
|
#else
|
|
#define RTC_FWD_DECL_OBJC_CLASS(classname) typedef struct objc_object classname
|
|
#endif
|
|
|
|
#endif // SDK_OBJC_BASE_RTCMACROS_H_
|