Reason for revert: Build issues have now _really_ been fixed Original issue's description: > Revert of move all reference to carbon api (patchset #2 id:300001 of https://codereview.webrtc.org/2321493002/ ) > > Reason for revert: > Still breaks Chromium mac compile: > [4542/22193] CXX obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > FAILED: obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/base/rtc_base/unixfilesystem.o.d -DLOGGING=1 -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DDCHECK_ALWAYS_ON=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=280106-1 -DCR_XCODE_VERSION=0511 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH -DENABLE_EXTERNAL_AUTH -DHAVE_OPENSSL_SSL_H -DHAVE_SCTP -DHAVE_SRTP -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC -DSRTP_RELATIVE_PATH -DSSL_USE_OPENSSL -DUSE_WEBRTC_DEV_BRANCH -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DLOGGING=1 -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DNO_MAIN_THREAD_WRAPPING -I../../third_party/webrtc_overrides -I../../third_party/boringssl/src/include -I../.. -Igen -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/boringssl/src/include -Wno-uninitialized -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -O2 -g1 -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Werror -Wall -Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../third_party/webrtc/base/unixfilesystem.cc -o obj/third_party/webrtc/base/rtc_base/unixfilesystem.o > ../../third_party/webrtc/base/unixfilesystem.cc:375:11: error: variable has incomplete type 'FSRef' > FSRef fr; > ^ > /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFURL.h:467:8: note: forward declaration of 'FSRef' > struct FSRef; > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:376:27: error: use of undeclared identifier 'kUserDomain' > if (0 != FSFindFolder(kUserDomain, kApplicationSupportFolderType, > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:376:40: error: use of undeclared identifier 'kApplicationSupportFolderType' > if (0 != FSFindFolder(kUserDomain, kApplicationSupportFolderType, > ^ > ../../third_party/webrtc/base/unixfilesystem.cc:377:27: error: use of undeclared identifier 'kCreateFolder'; did you mean 'CreateFolder'? > kCreateFolder, &fr)) > ^~~~~~~~~~~~~ > CreateFolder > ../../third_party/webrtc/base/unixfilesystem.cc:92:22: note: 'CreateFolder' declared here > bool UnixFilesystem::CreateFolder(const Pathname &path, mode_t mode) { > > Original issue's description: > > Reland of move all reference to carbon api (patchset #1 id:1 of https://codereview.webrtc.org/2316563002/ ) > > > > Reason for revert: > > Chromium build issues have been resolved. > > > > Original issue's description: > > > Revert of Remove all reference to carbon api (patchset #2 id:20001 of https://codereview.webrtc.org/2299633002/ ) > > > > > > Reason for revert: > > > Breaks chromium build > > > > > > Original issue's description: > > > > Remove all reference to carbon api > > > > > > > > BUG=webrtc:6282 > > > > > > > > Committed: https://crrev.com/dbd8b6bec4143c940b2f2ca8cd85c25d17327964 > > > > Cr-Commit-Position: refs/heads/master@{#14080} > > > > > > TBR=magjed@webrtc.org,mflodman@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:6282 > > > > > > Committed: https://crrev.com/b096aa7fd375a980daab3a986596548ca5de2a1c > > > Cr-Commit-Position: refs/heads/master@{#14081} > > > > TBR=magjed@webrtc.org,mflodman@webrtc.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=webrtc:6282 > > > > Committed: https://crrev.com/a90879b64fd8db57c0274169311d6b51dd59f1a0 > > Cr-Commit-Position: refs/heads/master@{#14125} > > TBR=mflodman@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6282 > > Committed: https://crrev.com/4e0581f543b026cbc31c3b24cf65c7f51dcd6124 > Cr-Commit-Position: refs/heads/master@{#14133} TBR=mflodman@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6282 Review-Url: https://codereview.webrtc.org/2327573002 Cr-Commit-Position: refs/heads/master@{#14155}
166 lines
4.4 KiB
C++
166 lines
4.4 KiB
C++
/*
|
|
* Copyright 2009 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include <memory>
|
|
|
|
#include "webrtc/base/gunit.h"
|
|
#include "webrtc/base/socket_unittest.h"
|
|
#include "webrtc/base/thread.h"
|
|
#include "webrtc/base/macsocketserver.h"
|
|
|
|
namespace rtc {
|
|
|
|
class WakeThread : public Thread {
|
|
public:
|
|
WakeThread(SocketServer* ss) : ss_(ss) {
|
|
}
|
|
virtual ~WakeThread() {
|
|
Stop();
|
|
}
|
|
void Run() {
|
|
ss_->WakeUp();
|
|
}
|
|
private:
|
|
SocketServer* ss_;
|
|
};
|
|
|
|
// Test that MacAsyncSocket passes all the generic Socket tests.
|
|
class MacAsyncSocketTest : public SocketTest {
|
|
protected:
|
|
MacAsyncSocketTest()
|
|
: server_(CreateSocketServer()),
|
|
scope_(server_.get()) {}
|
|
// Override for other implementations of MacBaseSocketServer.
|
|
virtual MacBaseSocketServer* CreateSocketServer() {
|
|
return new MacCFSocketServer();
|
|
};
|
|
std::unique_ptr<MacBaseSocketServer> server_;
|
|
SocketServerScope scope_;
|
|
};
|
|
|
|
TEST_F(MacAsyncSocketTest, TestConnectIPv4) {
|
|
SocketTest::TestConnectIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestConnectIPv6) {
|
|
SocketTest::TestConnectIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestConnectWithDnsLookupIPv4) {
|
|
SocketTest::TestConnectWithDnsLookupIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestConnectWithDnsLookupIPv6) {
|
|
SocketTest::TestConnectWithDnsLookupIPv6();
|
|
}
|
|
|
|
// BUG=https://code.google.com/p/webrtc/issues/detail?id=2272
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestConnectFailIPv4) {
|
|
SocketTest::TestConnectFailIPv4();
|
|
}
|
|
|
|
// Flaky. See webrtc:4738.
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestConnectFailIPv6) {
|
|
SocketTest::TestConnectFailIPv6();
|
|
}
|
|
|
|
// Reenable once we have mac async dns
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestConnectWithDnsLookupFailIPv4) {
|
|
SocketTest::TestConnectWithDnsLookupFailIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestConnectWithDnsLookupFailIPv6) {
|
|
SocketTest::TestConnectWithDnsLookupFailIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestConnectWithClosedSocketIPv4) {
|
|
SocketTest::TestConnectWithClosedSocketIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestConnectWithClosedSocketIPv6) {
|
|
SocketTest::TestConnectWithClosedSocketIPv6();
|
|
}
|
|
|
|
// Flaky at the moment (10% failure rate). Seems the client doesn't get
|
|
// signalled in a timely manner...
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestServerCloseDuringConnectIPv4) {
|
|
SocketTest::TestServerCloseDuringConnectIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestServerCloseDuringConnectIPv6) {
|
|
SocketTest::TestServerCloseDuringConnectIPv6();
|
|
}
|
|
// Flaky at the moment (0.5% failure rate). Seems the client doesn't get
|
|
// signalled in a timely manner...
|
|
TEST_F(MacAsyncSocketTest, TestClientCloseDuringConnectIPv4) {
|
|
SocketTest::TestClientCloseDuringConnectIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestClientCloseDuringConnectIPv6) {
|
|
SocketTest::TestClientCloseDuringConnectIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestServerCloseIPv4) {
|
|
SocketTest::TestServerCloseIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestServerCloseIPv6) {
|
|
SocketTest::TestServerCloseIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestCloseInClosedCallbackIPv4) {
|
|
SocketTest::TestCloseInClosedCallbackIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestCloseInClosedCallbackIPv6) {
|
|
SocketTest::TestCloseInClosedCallbackIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestSocketServerWaitIPv4) {
|
|
SocketTest::TestSocketServerWaitIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestSocketServerWaitIPv6) {
|
|
SocketTest::TestSocketServerWaitIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestTcpIPv4) {
|
|
SocketTest::TestTcpIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestTcpIPv6) {
|
|
SocketTest::TestTcpIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestSingleFlowControlCallbackIPv4) {
|
|
SocketTest::TestSingleFlowControlCallbackIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, TestSingleFlowControlCallbackIPv6) {
|
|
SocketTest::TestSingleFlowControlCallbackIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestUdpIPv4) {
|
|
SocketTest::TestUdpIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestUdpIPv6) {
|
|
SocketTest::TestUdpIPv6();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestGetSetOptionsIPv4) {
|
|
SocketTest::TestGetSetOptionsIPv4();
|
|
}
|
|
|
|
TEST_F(MacAsyncSocketTest, DISABLED_TestGetSetOptionsIPv6) {
|
|
SocketTest::TestGetSetOptionsIPv6();
|
|
}
|
|
} // namespace rtc
|