f70fbc8411
This change introduces a new non-reentrant mutex to WebRTC. It enables eventual migration to Abseil's mutex. The mutex types supportable by webrtc::Mutex are - absl::Mutex - CriticalSection (Windows only) - pthread_mutex (POSIX only) In addition to introducing the mutexes, the CL also changes PacketBuffer to use the new mutex instead of rtc::CriticalSection. The method of yielding from critical_section.cc was given a mini-cleanup and YieldCurrentThread() was added to rtc_base/synchronization/yield.h/cc. Additionally, google_benchmark benchmarks for the mutexes were added (test courtesy of danilchap@), and some results from a pthread/Abseil shootout were added showing Abseil has the advantage in higher contention. Bug: webrtc:11567, webrtc:11634 Change-Id: Iaec324ccb32ec3851bf6db3fd290f5ea5dee4c81 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176230 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Tommi <tommi@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#31443}
131 lines
2.7 KiB
Plaintext
131 lines
2.7 KiB
Plaintext
# Copyright (c) 2018 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import("../../webrtc.gni")
|
|
if (is_android) {
|
|
import("//build/config/android/config.gni")
|
|
import("//build/config/android/rules.gni")
|
|
}
|
|
import("//third_party/google_benchmark/buildconfig.gni")
|
|
|
|
rtc_library("yield") {
|
|
sources = [
|
|
"yield.cc",
|
|
"yield.h",
|
|
]
|
|
deps = []
|
|
}
|
|
|
|
rtc_library("mutex") {
|
|
sources = [
|
|
"mutex.cc",
|
|
"mutex.h",
|
|
"mutex_abseil.h",
|
|
"mutex_critical_section.h",
|
|
"mutex_pthread.h",
|
|
]
|
|
deps = [
|
|
":yield",
|
|
"..:checks",
|
|
"..:macromagic",
|
|
"../system:unused",
|
|
"//third_party/abseil-cpp/absl/base:core_headers",
|
|
"//third_party/abseil-cpp/absl/synchronization",
|
|
]
|
|
}
|
|
|
|
rtc_library("rw_lock_wrapper") {
|
|
public = [ "rw_lock_wrapper.h" ]
|
|
sources = [ "rw_lock_wrapper.cc" ]
|
|
deps = [ "..:macromagic" ]
|
|
if (is_win) {
|
|
sources += [
|
|
"rw_lock_win.cc",
|
|
"rw_lock_win.h",
|
|
]
|
|
deps += [ "..:logging" ]
|
|
} else {
|
|
sources += [
|
|
"rw_lock_posix.cc",
|
|
"rw_lock_posix.h",
|
|
]
|
|
}
|
|
}
|
|
|
|
rtc_library("sequence_checker") {
|
|
sources = [
|
|
"sequence_checker.cc",
|
|
"sequence_checker.h",
|
|
]
|
|
deps = [
|
|
"..:checks",
|
|
"..:criticalsection",
|
|
"..:macromagic",
|
|
"..:platform_thread_types",
|
|
"../../api/task_queue",
|
|
"../system:rtc_export",
|
|
]
|
|
}
|
|
|
|
rtc_library("yield_policy") {
|
|
sources = [
|
|
"yield_policy.cc",
|
|
"yield_policy.h",
|
|
]
|
|
deps = [
|
|
"..:checks",
|
|
"//third_party/abseil-cpp/absl/base:config",
|
|
"//third_party/abseil-cpp/absl/base:core_headers",
|
|
]
|
|
}
|
|
|
|
if (rtc_include_tests) {
|
|
rtc_library("synchronization_unittests") {
|
|
testonly = true
|
|
sources = [
|
|
"mutex_unittest.cc",
|
|
"yield_policy_unittest.cc",
|
|
]
|
|
deps = [
|
|
":mutex",
|
|
":yield",
|
|
":yield_policy",
|
|
"..:checks",
|
|
"..:macromagic",
|
|
"..:rtc_base",
|
|
"..:rtc_event",
|
|
"../../test:test_support",
|
|
"//third_party/google_benchmark",
|
|
]
|
|
}
|
|
|
|
rtc_library("mutex_benchmark") {
|
|
testonly = true
|
|
sources = [ "mutex_benchmark.cc" ]
|
|
deps = [
|
|
":mutex",
|
|
"//third_party/google_benchmark",
|
|
]
|
|
}
|
|
|
|
rtc_library("sequence_checker_unittests") {
|
|
testonly = true
|
|
|
|
sources = [ "sequence_checker_unittest.cc" ]
|
|
deps = [
|
|
":sequence_checker",
|
|
"..:checks",
|
|
"..:rtc_base_approved",
|
|
"..:task_queue_for_test",
|
|
"../../api:function_view",
|
|
"../../test:test_main",
|
|
"../../test:test_support",
|
|
]
|
|
}
|
|
}
|