33f38f2f38
Bug: webrtc:360058654 Change-Id: Ida26eca237c4f882cf03204a3d87780c25c1890c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/371640 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#43604}
94 lines
3.5 KiB
C++
94 lines
3.5 KiB
C++
/*
|
|
* Copyright (c) 2024 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "media/base/codec_list.h"
|
|
|
|
#include <cstddef>
|
|
#include <map>
|
|
|
|
#include "media/base/codec.h"
|
|
#include "media/base/media_constants.h"
|
|
#include "rtc_base/checks.h"
|
|
#include "rtc_base/logging.h"
|
|
#include "rtc_base/string_encode.h"
|
|
|
|
namespace cricket {
|
|
|
|
void CodecList::CheckConsistency() {
|
|
#if RTC_DCHECK_IS_ON
|
|
std::map<int, int> pt_to_index;
|
|
// Create a map of payload type to index, and ensure
|
|
// that there are no duplicates.
|
|
for (size_t i = 0; i < codecs_.size(); i++) {
|
|
const Codec& codec = codecs_[i];
|
|
if (codec.id != Codec::kIdNotSet) {
|
|
// Not true - the test PeerConnectionMediaTest.RedFmtpPayloadMixed
|
|
// fails this check. In that case, the duplicates are identical.
|
|
// TODO: https://issues.webrtc.org/384756621 - fix test and enable check.
|
|
// RTC_DCHECK(pt_to_index.count(codec.id) == 0);
|
|
if (pt_to_index.count(codec.id) != 0) {
|
|
RTC_LOG(LS_WARNING) << "Surprising condition: Two codecs on same PT. "
|
|
<< "First: " << codecs_[pt_to_index[codec.id]]
|
|
<< " Second: " << codec;
|
|
// Skip this codec in the map, and go on.
|
|
continue;
|
|
}
|
|
pt_to_index.insert({codec.id, i});
|
|
}
|
|
}
|
|
for (Codec& codec : codecs_) {
|
|
switch (codec.GetResiliencyType()) {
|
|
case Codec::ResiliencyType::kRed:
|
|
// Check that the target codec exists
|
|
break;
|
|
case Codec::ResiliencyType::kRtx: {
|
|
// Check that the target codec exists
|
|
const auto apt_it = codec.params.find(kCodecParamAssociatedPayloadType);
|
|
// Not true - there's a test that deliberately injects a wrong
|
|
// RTX codec (MediaSessionDescriptionFactoryTest.RtxWithoutApt)
|
|
// TODO: https://issues.webrtc.org/384756622 - reject codec earlier and
|
|
// enable check. RTC_DCHECK(apt_it != codec.params.end()); Until that is
|
|
// fixed:
|
|
if (apt_it == codec.params.end()) {
|
|
RTC_LOG(LS_WARNING) << "Surprising condition: RTX codec without"
|
|
<< " apt parameter: " << codec;
|
|
break;
|
|
}
|
|
int associated_pt;
|
|
RTC_DCHECK(rtc::FromString(apt_it->second, &associated_pt));
|
|
// Not true:
|
|
// RTC_DCHECK(pt_to_index.count(associated_pt) == 1);
|
|
// TODO: https://issues.webrtc.org/384954756 - drop codecs before we get
|
|
// here
|
|
if (pt_to_index.count(associated_pt) != 1) {
|
|
RTC_LOG(LS_WARNING)
|
|
<< "Surprising condition: RTX codec APT not found: " << codec;
|
|
}
|
|
// const Codec& referred_codec = codecs_[pt_to_index[associated_pt]];
|
|
// Not true:
|
|
// RTC_DCHECK(referred_codec.type == Codec::Type::kVideo);
|
|
// Not true:
|
|
// RTC_DCHECK(referred_codec.GetResiliencyType() ==
|
|
// Codec::ResiliencyType::kNone);
|
|
// TODO: https://issues.webrtc.org/384756623 - figure out if this is
|
|
// expected or not.
|
|
break;
|
|
}
|
|
case Codec::ResiliencyType::kNone:
|
|
break; // nothing to see here
|
|
default:
|
|
break; // don't know what to check yet
|
|
}
|
|
}
|
|
#endif
|
|
}
|
|
|
|
} // namespace cricket
|