Alessio Bazzica
f2a2fe84b8
Reland "RNN VAD: pitch search optimizations (part 3)"
This reverts commit 57e68ee1b94cce853ab4305680bbe71c01f95e82.
Reason for revert: bug in ancestor CL fixed
Original change's description:
> Revert "RNN VAD: pitch search optimizations (part 3)"
>
> This reverts commit ea89f2a447c514b73da2ed6189fe4b8485f123c6.
>
> Reason for revert: bug in ancestor CL https://webrtc-review.googlesource.com/c/src/+/191320
>
> Original change's description:
> > RNN VAD: pitch search optimizations (part 3)
> >
> > `ComputeSlidingFrameSquareEnergies()` which computes the energy of a
> > sliding 20 ms frame in the pitch buffer has been switched from backward
> > to forward.
> >
> > The benchmark has shown a slight improvement (about +6x).
> >
> > This change is not bit exact but all the tolerance tests still pass
> > except for one single case in `RnnVadTest,PitchSearchWithinTolerance`
> > for which the tolerance has been slightly increased. Note that the pitch
> > estimation is still bit-exact.
> >
> > Benchmarked as follows:
> > ```
> > out/release/modules_unittests \
> > --gtest_filter=*RnnVadTest.DISABLED_RnnVadPerformance* \
> > --gtest_also_run_disabled_tests --logs
> > ```
> >
> > Results:
> >
> > | baseline | this CL
> > ------+----------------------+------------------------
> > run 1 | 22.8319 +/- 1.46554 | 22.087 +/- 0.552932
> > | 389.367x | 402.499x
> > ------+----------------------+------------------------
> > run 2 | 22.4286 +/- 0.726449 | 22.216 +/- 0.916222
> > | 396.369x | 400.162x
> > ------+----------------------+------------------------
> > run 2 | 22.5688 +/- 0.831341 | 22.4902 +/- 1.04881
> > | 393.906x | 395.283x
> >
> > Bug: webrtc:10480
> > Change-Id: I1fd54077a32e25e46196c8e18f003cd0ffd503e1
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191703
> > Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> > Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> > Cr-Commit-Position: refs/heads/master@{#32572}
>
> TBR=alessiob@webrtc.org,kwiberg@webrtc.org
>
> Change-Id: I57a8f937ade0a35e1ccf0e229c391cc3a10e7c48
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:10480
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192621
> Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32578}
TBR=alessiob@webrtc.org,kwiberg@webrtc.org
# Not skipping CQ checks because this is a reland.
Bug: webrtc:10480
Change-Id: I1d510697236255d8c0cca405e90781f5d8c6a3e6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/192783
Commit-Queue: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Alessio Bazzica <alessiob@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32587}
2020-11-11 13:46:02 +00:00
..
2020-11-02 10:42:10 +00:00
2020-08-18 12:29:32 +00:00
2020-09-06 10:38:23 +00:00
2020-09-29 10:19:20 +00:00
2020-11-11 13:46:02 +00:00
2019-07-08 13:45:15 +00:00
2020-11-09 10:47:55 +00:00
2020-09-29 10:19:20 +00:00
2020-09-06 10:38:23 +00:00
2020-11-09 10:47:55 +00:00
2020-04-27 11:47:15 +00:00
2020-05-26 20:27:34 +00:00
2020-04-21 09:06:37 +00:00
2020-05-26 20:27:34 +00:00
2020-03-16 11:51:47 +00:00
2020-03-16 11:51:47 +00:00
2019-08-22 10:34:05 +00:00
2020-09-02 20:28:49 +00:00
2020-07-07 14:35:58 +00:00
2020-09-02 20:28:49 +00:00
2020-11-09 10:47:55 +00:00
2020-09-03 12:43:14 +00:00
2020-08-20 16:13:12 +00:00
2020-10-14 12:18:57 +00:00
2020-09-29 10:19:20 +00:00
2020-08-18 12:29:32 +00:00
2019-08-22 10:34:05 +00:00
2020-01-31 07:14:25 +00:00
2020-01-31 07:14:25 +00:00
2020-07-16 13:52:28 +00:00
2020-01-17 10:09:09 +00:00
2020-01-17 10:09:09 +00:00
2020-01-17 10:09:09 +00:00
2020-10-14 12:00:54 +00:00
2020-10-14 12:00:54 +00:00
2020-10-14 12:00:54 +00:00
2019-12-18 16:01:24 +00:00
2019-12-18 16:01:24 +00:00
2020-01-03 14:10:21 +00:00
2019-10-11 18:08:17 +00:00
2019-10-11 18:08:17 +00:00
2019-10-11 18:08:17 +00:00
2020-04-27 11:47:15 +00:00
2020-04-27 11:47:15 +00:00
2020-02-19 14:05:46 +00:00
2020-04-29 14:29:27 +00:00
2019-08-22 10:34:05 +00:00
2019-08-20 08:36:47 +00:00
2019-08-20 08:36:47 +00:00
2019-12-09 13:55:50 +00:00
2019-08-22 10:34:05 +00:00
2020-02-24 13:19:14 +00:00
2020-02-24 13:19:14 +00:00
2020-02-24 13:19:14 +00:00
2020-02-24 13:19:14 +00:00
2019-10-07 13:06:05 +00:00
2020-03-17 13:55:41 +00:00
2019-10-07 13:06:05 +00:00