admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/pc
History
Bjorn A Mellem fc604aa990 Unset sinks when deleting CompositeDataChannelTransport. 
This fixes a DCHECK during teardown in the case when the primary
DataChannelTranspot (eg. DatagramTransport) is successfully negotiated.
DatagramTransport expects the DataSink to be unset before it's deleted.

This was not caught by existing tests because the fallback transport
(SctpDataChannelTransport) does not have the same DCHECK.

Also adds a regression test for the issue, in which SCTP is available
as a fallback but DataChannelTransport is negotiated successfully.

Bug: webrtc:9719
Change-Id: I414d964d3c85d3d01cdb5e34d6b248659a613c39
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154365
Commit-Queue: Bjorn Mellem <mellem@webrtc.org>
Reviewed-by: Seth Hampson <shampson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29292}
2019-09-24 22:35:44 +00:00
..
test
Delete almost all default methods on PeerConnectionInterface
2019-09-18 16:27:44 +00:00
audio_rtp_receiver.cc
Refactor Rtp Receivers to accept SSRC 0.
2019-09-16 21:29:58 +00:00
audio_rtp_receiver.h
Refactor Rtp Receivers to accept SSRC 0.
2019-09-16 21:29:58 +00:00
audio_track.cc
Deprecating ThreadChecker specific interface.
2019-04-08 16:58:07 +00:00
audio_track.h
…
BUILD.gn
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
channel_interface.h
…
channel_manager_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
channel_manager.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
channel_manager.h
Move MediaTransportInterface out of the libjingle_peerconnection_api target
2019-09-13 10:49:56 +00:00
channel_unittest.cc
Proxy OnRtcpPacketReceived to the worker thread in channel tests.
2019-09-23 19:59:48 +00:00
channel.cc
Only handle each RTCP once.
2019-09-18 16:54:39 +00:00
channel.h
Only handle each RTCP once.
2019-09-18 16:54:39 +00:00
composite_data_channel_transport.cc
Unset sinks when deleting CompositeDataChannelTransport.
2019-09-24 22:35:44 +00:00
composite_data_channel_transport.h
Unset sinks when deleting CompositeDataChannelTransport.
2019-09-24 22:35:44 +00:00
composite_rtp_transport_test.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
composite_rtp_transport.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
composite_rtp_transport.h
Reland: Implement true negotiation for DatagramTransport with fallback to RTP.
2019-06-07 20:14:36 +00:00
data_channel_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
data_channel.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
data_channel.h
Make ID of datachannel stats not depend on dc.id
2019-07-31 13:19:08 +00:00
datagram_rtp_transport.cc
Make the RtpHeaderParserImpl available to tests and tools only.
2019-08-29 15:56:40 +00:00
datagram_rtp_transport.h
Move MediaTransportInterface out of the libjingle_peerconnection_api target
2019-09-13 10:49:56 +00:00
DEPS
…
dtls_srtp_transport_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
dtls_srtp_transport.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
dtls_srtp_transport.h
…
dtls_transport_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
dtls_transport.cc
Expose SSL ciphersuite on the webrtc::DtlsTransport interface
2019-04-12 08:29:59 +00:00
dtls_transport.h
Delete unneeded includes of async_invoker.h
2019-04-16 07:28:06 +00:00
dtmf_sender_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
dtmf_sender.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
dtmf_sender.h
…
external_hmac.cc
…
external_hmac.h
…
ice_server_parsing_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
ice_server_parsing.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
ice_server_parsing.h
Export symbols needed by the Chromium component build (part 8).
2019-04-02 10:13:36 +00:00
ice_transport_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
ice_transport.cc
Fix comment - ice transport is cleared on the networking thread.
2019-04-09 09:12:10 +00:00
ice_transport.h
…
jitter_buffer_delay_interface.h
Remove SetLatency/GetLatency from MediaSourceInterface API level
2019-04-18 19:11:31 +00:00
jitter_buffer_delay_proxy.h
Remove SetLatency/GetLatency from MediaSourceInterface API level
2019-04-18 19:11:31 +00:00
jitter_buffer_delay_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
jitter_buffer_delay.cc
Remove SetLatency/GetLatency from MediaSourceInterface API level
2019-04-18 19:11:31 +00:00
jitter_buffer_delay.h
Remove SetLatency/GetLatency from MediaSourceInterface API level
2019-04-18 19:11:31 +00:00
jsep_ice_candidate.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
jsep_session_description_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
jsep_session_description.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
jsep_transport_controller_unittest.cc
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
jsep_transport_controller.cc
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
jsep_transport_controller.h
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
jsep_transport_unittest.cc
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
jsep_transport.cc
Unset sinks when deleting CompositeDataChannelTransport.
2019-09-24 22:35:44 +00:00
jsep_transport.h
Unset sinks when deleting CompositeDataChannelTransport.
2019-09-24 22:35:44 +00:00
local_audio_source_unittest.cc
…
local_audio_source.cc
…
local_audio_source.h
…
media_protocol_names.cc
Reland "Reland "Version 2 "Refactoring DataContentDescription class"""
2019-05-13 18:37:47 +00:00
media_protocol_names.h
Reland "Reland "Version 2 "Refactoring DataContentDescription class"""
2019-05-13 18:37:47 +00:00
media_session_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
media_session.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
media_session.h
Add support for two-byte RTP header extensions to UsedRtpHeaderExtensionIds
2019-06-24 08:50:07 +00:00
media_stream_observer.cc
…
media_stream_observer.h
…
media_stream_track.h
…
media_stream_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
media_stream.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
media_stream.h
…
OWNERS
Remove zhihuang@webrtc.org from OWNERS
2019-08-19 22:37:51 +00:00
peer_connection_bundle_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_crypto_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_data_channel_unittest.cc
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
peer_connection_end_to_end_unittest.cc
Delete AudioDecoder method IncomingPacket
2019-09-24 08:30:24 +00:00
peer_connection_factory_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
peer_connection_factory.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_factory.h
Move MediaTransportInterface out of the libjingle_peerconnection_api target
2019-09-13 10:49:56 +00:00
peer_connection_histogram_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_ice_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_integrationtest.cc
Unset sinks when deleting CompositeDataChannelTransport.
2019-09-24 22:35:44 +00:00
peer_connection_interface_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_internal.h
Use RtpSender/RtpReceiver track ID for legacy GetStats
2019-03-27 18:14:00 +00:00
peer_connection_jsep_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_media_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_rampup_tests.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_rtp_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_signaling_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_simulcast_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
peer_connection_wrapper.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
peer_connection_wrapper.h
Move rtc::FunctionView to the public API
2019-03-21 15:23:05 +00:00
peer_connection.cc
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
peer_connection.h
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
proxy_unittest.cc
Fully qualify googletest symbols.
2019-04-09 17:18:20 +00:00
remote_audio_source.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
remote_audio_source.h
Remove SetLatency/GetLatency from MediaSourceInterface API level
2019-04-18 19:11:31 +00:00
rtc_stats_collector_unittest.cc
Always pass arguments to INSTANTIATE_TEST_SUITE_P.
2019-09-24 08:56:24 +00:00
rtc_stats_collector.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
rtc_stats_collector.h
Implement RTCRemoteInboundRtpStreamStats for both audio and video.
2019-05-27 12:45:22 +00:00
rtc_stats_integrationtest.cc
Fix rare audioLevel flake in RTCStatsIntegrationTest.
2019-09-13 11:35:22 +00:00
rtc_stats_traversal_unittest.cc
Fully qualify googletest symbols.
2019-04-09 17:18:20 +00:00
rtc_stats_traversal.cc
Implement RTCRemoteInboundRtpStreamStats for both audio and video.
2019-05-27 12:45:22 +00:00
rtc_stats_traversal.h
…
rtcp_mux_filter_unittest.cc
…
rtcp_mux_filter.cc
…
rtcp_mux_filter.h
…
rtp_media_utils_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_media_utils.cc
Reland "Make negotiationneeded processing in PeerConnection spec compliant."
2019-04-16 12:04:33 +00:00
rtp_media_utils.h
Reland "Make negotiationneeded processing in PeerConnection spec compliant."
2019-04-16 12:04:33 +00:00
rtp_parameters_conversion_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_parameters_conversion.cc
Negotiate use of RTCP loss notification feedback (LNTF)
2019-05-24 12:44:14 +00:00
rtp_parameters_conversion.h
…
rtp_receiver.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_receiver.h
Refactor Rtp Receivers to accept SSRC 0.
2019-09-16 21:29:58 +00:00
rtp_sender_receiver_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
rtp_sender.cc
Guard GenerateUniqueId() against concurrent access.
2019-07-26 17:52:49 +00:00
rtp_sender.h
Add RtpSenderInterface.SetStreams
2019-05-20 18:38:06 +00:00
rtp_transceiver_unittest.cc
…
rtp_transceiver.cc
Implement RTCRtpTransceiver.setCodecPreferences
2019-05-01 20:14:59 +00:00
rtp_transceiver.h
Implement RTCRtpTransceiver.setCodecPreferences
2019-05-01 20:14:59 +00:00
rtp_transport_internal.h
Remove rtp_ and rtcp_packet_transport() from the RtpTransport interface.
2019-05-24 23:58:46 +00:00
rtp_transport_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_transport.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rtp_transport.h
Remove rtp_ and rtcp_packet_transport() from the RtpTransport interface.
2019-05-24 23:58:46 +00:00
sctp_data_channel_transport.cc
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
sctp_data_channel_transport.h
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
sctp_transport_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
sctp_transport.cc
Implement max-channels for SCTP datachannels.
2019-05-21 10:24:41 +00:00
sctp_transport.h
Implement max-channels for SCTP datachannels.
2019-05-21 10:24:41 +00:00
sctp_utils_unittest.cc
Fully qualify googletest symbols.
2019-04-09 17:18:20 +00:00
sctp_utils.cc
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
sctp_utils.h
Reland "Reland "Refactor SCTP data channels to use DataChannelTransportInterface.""
2019-09-24 17:10:52 +00:00
sdp_serializer_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
sdp_serializer.cc
Reland "Adding a restriction for legal RID values."
2019-04-09 21:19:31 +00:00
sdp_serializer.h
…
sdp_utils.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
sdp_utils.h
…
session_description_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
session_description.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
session_description.h
Adds test for experimental remote estimate SDP negotiation.
2019-07-24 15:29:24 +00:00
simulcast_description.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
simulcast_description.h
…
srtp_filter_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
srtp_filter.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
srtp_filter.h
…
srtp_session_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
srtp_session.cc
Deprecating ThreadChecker specific interface.
2019-04-08 16:58:07 +00:00
srtp_session.h
…
srtp_transport_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
srtp_transport.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
srtp_transport.h
Format almost everything.
2019-07-08 13:45:15 +00:00
stats_collector_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
stats_collector.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
stats_collector.h
Reporting audio device underrun counter
2019-08-16 11:49:55 +00:00
stream_collection.h
…
track_media_info_map_unittest.cc
Split out RtpSource from libjingle_peerconnection_api
2019-09-02 14:04:47 +00:00
track_media_info_map.cc
…
track_media_info_map.h
…
transport_stats.cc
…
transport_stats.h
Add support for RTCTransportStats.selectedCandidatePairChanges
2019-08-28 13:22:08 +00:00
used_ids_unittest.cc
Always pass arguments to INSTANTIATE_TEST_SUITE_P.
2019-09-24 08:56:24 +00:00
used_ids.h
Add support for two-byte RTP header extensions to UsedRtpHeaderExtensionIds
2019-06-24 08:50:07 +00:00
video_rtp_receiver.cc
Refactor Rtp Receivers to accept SSRC 0.
2019-09-16 21:29:58 +00:00
video_rtp_receiver.h
Refactor Rtp Receivers to accept SSRC 0.
2019-09-16 21:29:58 +00:00
video_track_source.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
video_track_source.h
…
video_track_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
video_track.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
video_track.h
…
webrtc_sdp_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
webrtc_sdp.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
webrtc_sdp.h
Export symbols needed by the Chromium component build (part 8).
2019-04-02 10:13:36 +00:00
webrtc_session_description_factory.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
webrtc_session_description_factory.h
Format almost everything.
2019-07-08 13:45:15 +00:00