4d706a9fd1
This reverts commit 55cdc29b9d7259d17ccc281855dd21adc51ca957.
Reason for revert: Breaks downstream project.
Original change's description:
> Reland "[Stats] Attribute::ToString(), to replace member ValueToString/ToJson."
>
> This is a reland of commit 54be7084e0861a0179a5fccd0b27edf7d7994bbb
>
> Original change's description:
> > [Stats] Attribute::ToString(), to replace member ValueToString/ToJson.
> >
> > Delete RTCStatsMember<T>::ValueToString() and ValueToJson() in favor of
> > Attribute::ToString().
> >
> > The difference between "ToString" and "ToJson" is that the "ToJson"
> > version converts 64-bit integers and doubles to floating points with no
> > more than ~15 digits of precision as to not exceed JSON's precision
> > limitations. So only in edge cases of really large numbers or numbers
> > with a silly number of digits will the two methods produce different
> > results. Also JSON puts '\"' around map key names, e.g. "{\"foo\":123}"
> > as opposed to "{foo:123}".
> >
> > Going forward we see no reason to maintain two different string
> > converted paths that are this similar, so we only implement one
> > Attribute::ToString() method which does what "ToJson" did.
> >
> > In the next CL we can delete RTCStatsMember<T>.
> >
> > Bug: webrtc:15164
> > Change-Id: Iaa8cf3bf14b40dc44664f75989832469603131c5
> > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334640
> > Commit-Queue: Henrik Boström <hbos@webrtc.org>
> > Reviewed-by: Evan Shrubsole <eshr@google.com>
> > Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> > Cr-Commit-Position: refs/heads/main@{#41544}
>
> Bug: webrtc:15164
> Change-Id: If34509ebf3d7c0291442ae11596e7c2d3978fb64
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335240
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41566}
Bug: webrtc:15164
Change-Id: I5819811237a6dbd85a8c738ca0180039fc705909
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/335280
Reviewed-by: Christoffer Dewerin <jansson@google.com>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41567}
98 lines
3.2 KiB
C++
98 lines
3.2 KiB
C++
/*
|
|
* Copyright 2024 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef API_STATS_ATTRIBUTE_H_
|
|
#define API_STATS_ATTRIBUTE_H_
|
|
|
|
#include <map>
|
|
#include <memory>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "absl/types/variant.h"
|
|
#include "api/stats/rtc_stats_member.h"
|
|
#include "rtc_base/system/rtc_export.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// A light-weight wrapper of an RTCStats attribute (an individual metric).
|
|
class RTC_EXPORT Attribute {
|
|
public:
|
|
// TODO(https://crbug.com/webrtc/15164): Replace uses of RTCStatsMember<T>
|
|
// with absl::optional<T> and update these pointer types.
|
|
typedef absl::variant<const RTCStatsMember<bool>*,
|
|
const RTCStatsMember<int32_t>*,
|
|
const RTCStatsMember<uint32_t>*,
|
|
const RTCStatsMember<int64_t>*,
|
|
const RTCStatsMember<uint64_t>*,
|
|
const RTCStatsMember<double>*,
|
|
const RTCStatsMember<std::string>*,
|
|
const RTCStatsMember<std::vector<bool>>*,
|
|
const RTCStatsMember<std::vector<int32_t>>*,
|
|
const RTCStatsMember<std::vector<uint32_t>>*,
|
|
const RTCStatsMember<std::vector<int64_t>>*,
|
|
const RTCStatsMember<std::vector<uint64_t>>*,
|
|
const RTCStatsMember<std::vector<double>>*,
|
|
const RTCStatsMember<std::vector<std::string>>*,
|
|
const RTCStatsMember<std::map<std::string, uint64_t>>*,
|
|
const RTCStatsMember<std::map<std::string, double>>*>
|
|
StatVariant;
|
|
|
|
template <typename T>
|
|
explicit Attribute(const char* name, const RTCStatsMember<T>* attribute)
|
|
: name_(name), attribute_(attribute) {}
|
|
|
|
const char* name() const;
|
|
const StatVariant& as_variant() const;
|
|
|
|
bool has_value() const;
|
|
template <typename T>
|
|
bool holds_alternative() const {
|
|
return absl::holds_alternative<const RTCStatsMember<T>*>(attribute_);
|
|
}
|
|
template <typename T>
|
|
absl::optional<T> as_optional() const {
|
|
RTC_CHECK(holds_alternative<T>());
|
|
if (!has_value()) {
|
|
return absl::nullopt;
|
|
}
|
|
return absl::optional<T>(get<T>());
|
|
}
|
|
template <typename T>
|
|
const T& get() const {
|
|
RTC_CHECK(holds_alternative<T>());
|
|
RTC_CHECK(has_value());
|
|
return absl::get<const RTCStatsMember<T>*>(attribute_)->value();
|
|
}
|
|
|
|
bool is_sequence() const;
|
|
bool is_string() const;
|
|
std::string ValueToString() const;
|
|
std::string ValueToJson() const;
|
|
|
|
bool operator==(const Attribute& other) const;
|
|
bool operator!=(const Attribute& other) const;
|
|
|
|
private:
|
|
const char* name_;
|
|
StatVariant attribute_;
|
|
};
|
|
|
|
struct RTC_EXPORT AttributeInit {
|
|
AttributeInit(const char* name, const Attribute::StatVariant& variant);
|
|
|
|
const char* name;
|
|
Attribute::StatVariant variant;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // API_STATS_ATTRIBUTE_H_
|