This reverts commit 27f3bf512827b483f9e0c67ce76362d83faa1950. Reason for revert: Broken internal project. Original change's description: > Reland "Replace BundleFilter with RtpDemuxer in RtpTransport." > > This reverts commit 97d5e5b32c77bf550f1d788454f2db10ac9fbb1c. > > Reason for revert: <INSERT REASONING HERE> > > Original change's description: > > Revert "Replace BundleFilter with RtpDemuxer in RtpTransport." > > > > This reverts commit ea8b62a3e74fe91cd6bf66304839cd5677880a4e. > > > > Reason for revert: Broke chromium tests. > > Original change's description: > > > Replace BundleFilter with RtpDemuxer in RtpTransport. > > > > > > BundleFilter is replaced by RtpDemuxer in RtpTransport for payload > > > type-based demuxing. RtpTransport will support MID-based demuxing later. > > > > > > Each BaseChannel has its own RTP demuxing criteria and when connecting > > > to the RtpTransport, BaseChannel will register itself as a demuxer sink. > > > > > > The inheritance model is changed. New inheritance chain: > > > DtlsSrtpTransport->SrtpTransport->RtpTranpsort > > > > > > NOTE: > > > When RTCP packets are received, Call::DeliverRtcp will be called for > > > multiple times (webrtc:9035) which is an existing issue. With this CL, > > > it will become more of a problem and should be fixed. > > > > > > Bug: webrtc:8587 > > > Change-Id: I1d8a00443bd4bcbacc56e5e19b7294205cdc38f0 > > > Reviewed-on: https://webrtc-review.googlesource.com/61360 > > > Commit-Queue: Zhi Huang <zhihuang@webrtc.org> > > > Reviewed-by: Steve Anton <steveanton@webrtc.org> > > > Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#22613} > > > > TBR=steveanton@webrtc.org,deadbeef@webrtc.org,zhihuang@webrtc.org > > > > Change-Id: If245da9d1ce970ac8dab7f45015e9b268a5dbcbd > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:8587 > > Reviewed-on: https://webrtc-review.googlesource.com/64860 > > Reviewed-by: Zhi Huang <zhihuang@webrtc.org> > > Commit-Queue: Zhi Huang <zhihuang@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#22614} > > TBR=steveanton@webrtc.org,deadbeef@webrtc.org,zhihuang@webrtc.org > > Change-Id: I3c272588ab4388ecadc4edc6786d5195c701855f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:8587 > Reviewed-on: https://webrtc-review.googlesource.com/64862 > Commit-Queue: Zhi Huang <zhihuang@webrtc.org> > Reviewed-by: Zhi Huang <zhihuang@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#22615} TBR=steveanton@webrtc.org,deadbeef@webrtc.org,zhihuang@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8587 Change-Id: I694ce9a039ed52c5961cdc0cba57587bed4cbde4 Reviewed-on: https://webrtc-review.googlesource.com/65381 Reviewed-by: Zhi Huang <zhihuang@webrtc.org> Commit-Queue: Zhi Huang <zhihuang@webrtc.org> Cr-Commit-Position: refs/heads/master@{#22665}
94 lines
3.5 KiB
C++
94 lines
3.5 KiB
C++
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef PC_RTPTRANSPORTINTERNAL_H_
|
|
#define PC_RTPTRANSPORTINTERNAL_H_
|
|
|
|
#include <string>
|
|
|
|
#include "api/ortc/rtptransportinterface.h"
|
|
#include "api/umametrics.h"
|
|
#include "p2p/base/icetransportinternal.h"
|
|
#include "rtc_base/networkroute.h"
|
|
#include "rtc_base/sigslot.h"
|
|
|
|
namespace rtc {
|
|
class CopyOnWriteBuffer;
|
|
struct PacketOptions;
|
|
struct PacketTime;
|
|
} // namespace rtc
|
|
|
|
namespace webrtc {
|
|
|
|
// This represents the internal interface beneath RtpTransportInterface;
|
|
// it is not accessible to API consumers but is accessible to internal classes
|
|
// in order to send and receive RTP and RTCP packets belonging to a single RTP
|
|
// session. Additional convenience and configuration methods are also provided.
|
|
class RtpTransportInternal : public RtpTransportInterface,
|
|
public sigslot::has_slots<> {
|
|
public:
|
|
virtual void SetRtcpMuxEnabled(bool enable) = 0;
|
|
|
|
// TODO(zstein): Remove PacketTransport setters. Clients should pass these
|
|
// in to constructors instead and construct a new RtpTransportInternal instead
|
|
// of updating them.
|
|
virtual bool rtcp_mux_enabled() const = 0;
|
|
|
|
virtual rtc::PacketTransportInternal* rtp_packet_transport() const = 0;
|
|
virtual void SetRtpPacketTransport(rtc::PacketTransportInternal* rtp) = 0;
|
|
|
|
virtual rtc::PacketTransportInternal* rtcp_packet_transport() const = 0;
|
|
virtual void SetRtcpPacketTransport(rtc::PacketTransportInternal* rtcp) = 0;
|
|
|
|
// Called whenever a transport's ready-to-send state changes. The argument
|
|
// is true if all used transports are ready to send. This is more specific
|
|
// than just "writable"; it means the last send didn't return ENOTCONN.
|
|
sigslot::signal1<bool> SignalReadyToSend;
|
|
|
|
// TODO(zstein): Consider having two signals - RtpPacketReceived and
|
|
// RtcpPacketReceived.
|
|
// The first argument is true for RTCP packets and false for RTP packets.
|
|
sigslot::signal3<bool, rtc::CopyOnWriteBuffer*, const rtc::PacketTime&>
|
|
SignalPacketReceived;
|
|
|
|
// Called whenever the network route of the P2P layer transport changes.
|
|
// The argument is an optional network route.
|
|
sigslot::signal1<rtc::Optional<rtc::NetworkRoute>> SignalNetworkRouteChanged;
|
|
|
|
// Called whenever a transport's writable state might change. The argument is
|
|
// true if the transport is writable, otherwise it is false.
|
|
sigslot::signal1<bool> SignalWritableState;
|
|
|
|
sigslot::signal1<const rtc::SentPacket&> SignalSentPacket;
|
|
|
|
virtual bool IsWritable(bool rtcp) const = 0;
|
|
|
|
// TODO(zhihuang): Pass the |packet| by copy so that the original data
|
|
// wouldn't be modified.
|
|
virtual bool SendRtpPacket(rtc::CopyOnWriteBuffer* packet,
|
|
const rtc::PacketOptions& options,
|
|
int flags) = 0;
|
|
|
|
virtual bool SendRtcpPacket(rtc::CopyOnWriteBuffer* packet,
|
|
const rtc::PacketOptions& options,
|
|
int flags) = 0;
|
|
|
|
virtual bool HandlesPayloadType(int payload_type) const = 0;
|
|
|
|
virtual void AddHandledPayloadType(int payload_type) = 0;
|
|
|
|
virtual void SetMetricsObserver(
|
|
rtc::scoped_refptr<MetricsObserverInterface> metrics_observer) = 0;
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // PC_RTPTRANSPORTINTERNAL_H_
|