This CL is partly a test to see if there's an impact on binary size:
- Not a big difference for binaries (decrease): -776b to -4Kb
- For libraries (libwebrtc.a) it actually increases the size: +40Kb
Secondarily this CL is basically to introduce this pattern to the
code base. In terms of LOC, this makes things slightly more compact.
From:
class Foo {
public:
Foo() {
checker_.Detach();
}
private:
SequenceChecker checker_;
};
To:
class Foo {
public:
Foo() = default;
private:
SequenceChecker checker_{SequenceChecker::kDetached};
};
Bug: none
Change-Id: I59fc34ccea10847e13455a349851ce9a0af458e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299020
Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39664}
43 lines
1.3 KiB
C++
43 lines
1.3 KiB
C++
/*
|
|
* Copyright 2019 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#ifndef PC_JITTER_BUFFER_DELAY_H_
|
|
#define PC_JITTER_BUFFER_DELAY_H_
|
|
|
|
#include <stdint.h>
|
|
|
|
#include "absl/types/optional.h"
|
|
#include "api/sequence_checker.h"
|
|
#include "rtc_base/system/no_unique_address.h"
|
|
#include "rtc_base/thread_annotations.h"
|
|
|
|
namespace webrtc {
|
|
|
|
// JitterBufferDelay converts delay from seconds to milliseconds for the
|
|
// underlying media channel. It also handles cases when user sets delay before
|
|
// the start of media_channel by caching its request.
|
|
class JitterBufferDelay {
|
|
public:
|
|
JitterBufferDelay() = default;
|
|
|
|
void Set(absl::optional<double> delay_seconds);
|
|
int GetMs() const;
|
|
|
|
private:
|
|
RTC_NO_UNIQUE_ADDRESS SequenceChecker worker_thread_checker_{
|
|
SequenceChecker::kDetached};
|
|
absl::optional<double> cached_delay_seconds_
|
|
RTC_GUARDED_BY(&worker_thread_checker_);
|
|
};
|
|
|
|
} // namespace webrtc
|
|
|
|
#endif // PC_JITTER_BUFFER_DELAY_H_
|