Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed:ed754e71ae> > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed:11ed366c48TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927}
60 lines
2.2 KiB
Plaintext
60 lines
2.2 KiB
Plaintext
# Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
|
|
#
|
|
# Use of this source code is governed by a BSD-style license
|
|
# that can be found in the LICENSE file in the root of the source
|
|
# tree. An additional intellectual property rights grant can be found
|
|
# in the file PATENTS. All contributing project authors may
|
|
# be found in the AUTHORS file in the root of the source tree.
|
|
|
|
import("//build/dotfile_settings.gni")
|
|
|
|
# The location of the build configuration file.
|
|
buildconfig = "//build/config/BUILDCONFIG.gn"
|
|
|
|
# The secondary source root is a parallel directory tree where
|
|
# GN build files are placed when they can not be placed directly
|
|
# in the source tree, e.g. for third party source trees.
|
|
secondary_source = "//build/secondary/"
|
|
|
|
# These are the targets to check headers for by default. The files in targets
|
|
# matching these patterns (see "gn help label_pattern" for format) will have
|
|
# their includes checked for proper dependencies when you run either
|
|
# "gn check" or "gn gen --check".
|
|
# TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is done.
|
|
check_targets = [
|
|
"//webrtc/api/*",
|
|
"//webrtc/audio/*",
|
|
"//webrtc/base/*",
|
|
"//webrtc/call/*",
|
|
"//webrtc/common_video/*",
|
|
"//webrtc/common_audio/*",
|
|
"//webrtc/examples/*",
|
|
"//webrtc/logging/*",
|
|
"//webrtc/media/*",
|
|
"//webrtc/modules/*",
|
|
"//webrtc/ortc/*",
|
|
"//webrtc/p2p/*",
|
|
"//webrtc/sdk/*",
|
|
"//webrtc/stats/*",
|
|
"//webrtc/system_wrappers/*",
|
|
"//webrtc/tools/*",
|
|
"//webrtc/video/*",
|
|
"//webrtc/voice_engine/*",
|
|
]
|
|
|
|
# These are the list of GN files that run exec_script. This whitelist exists
|
|
# to force additional review for new uses of exec_script, which is strongly
|
|
# discouraged except for gypi_to_gn calls.
|
|
exec_script_whitelist = build_dotfile_settings.exec_script_whitelist
|
|
|
|
default_args = {
|
|
# Webrtc does not support component builds because we are not using the
|
|
# template "component" but we rely directly on "rtc_static_library" and
|
|
# "rtc_shared_library". This means that we cannot use the chromium default
|
|
# value for this argument.
|
|
# This also means that the user can override this value using --args or
|
|
# the args.gn file but this setting will be ignored because we don't support
|
|
# component builds.
|
|
is_component_build = false
|
|
}
|