e3e30ae5c5
This reverts commit f3a197e55323aee974a932c52dd19fa88e5d4e38. Reason for revert: Speculative revert, as this may'be broken some build bots Original change's description: > Add core multi-channel pipeline in AEC3 > This CL adds basic the basic pipeline to support multi-channel > processing in AEC3. > > Apart from that, it removes the 8 kHz processing support in several > places of the AEC3 code. > > Bug: webrtc:10913 > Change-Id: If5b75fa325ed0071deea94a7546cb4a7adf22137 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150332 > Commit-Queue: Per Åhgren <peah@webrtc.org> > Reviewed-by: Sam Zackrisson <saza@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#29017} TBR=saza@webrtc.org,peah@webrtc.org Change-Id: I877d2993b9ccf024bd1d57bca1513c3e24d0bed3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10913 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/150940 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/master@{#29022}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.