admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/modules/desktop_capture
History
Jeroen Dhollander 77d987a724 Fix crash when resizing the display 
This crash happened when:
   * The cursor was located in the corner
   * The screen was resized so that the cursor position is outside of the frame.

This caused us to add out-of-bound coordinates to the frame's updated_region, which caused crashes further down the pipeline.

Bug: chromium:1323241
Test: new unittest
Test: manually reproduced crash
Change-Id: Ie71db58c8a347f00af8a3803fcd55cdcad6eafac
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261263
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/main@{#36809}
2022-05-09 09:15:24 +00:00
..
linux
Add CFI-ICALL to avoid crash in PipeWire functions
2022-05-05 18:15:08 +00:00
mac
Filter out Mac StatusIndicator window from desktop capture list
2022-03-28 09:25:51 +00:00
win
Fix failing WGC tests on Win10
2022-05-06 23:46:42 +00:00
blank_detector_desktop_capturer_wrapper_unittest.cc
Fully qualify googletest symbols.
2019-04-09 17:18:20 +00:00
blank_detector_desktop_capturer_wrapper.cc
getDisplayMedia shows black window on Youtube PiP in Windows.
2022-03-16 22:06:04 +00:00
blank_detector_desktop_capturer_wrapper.h
getDisplayMedia shows black window on Youtube PiP in Windows.
2022-03-16 22:06:04 +00:00
BUILD.gn
Fix failing WGC tests on Win10
2022-05-06 23:46:42 +00:00
cropped_desktop_frame_unittest.cc
Make CroppedWindowCapturer more resilient
2021-10-01 18:23:59 +00:00
cropped_desktop_frame.cc
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
cropped_desktop_frame.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
cropping_window_capturer_win.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
cropping_window_capturer.cc
Make CroppedWindowCapturer more resilient
2021-10-01 18:23:59 +00:00
cropping_window_capturer.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
DEPS
Revert "Reland "PipeWire capturer: implement proper DMA-BUFs support"""
2021-09-03 11:28:26 +00:00
desktop_and_cursor_composer_unittest.cc
Fix crash when resizing the display
2022-05-09 09:15:24 +00:00
desktop_and_cursor_composer.cc
Fix crash when resizing the display
2022-05-09 09:15:24 +00:00
desktop_and_cursor_composer.h
wayland: Add a common interface for screencast and remote desktop portal
2022-03-31 15:30:07 +00:00
desktop_capture_metadata.h
wayland: Add a common interface for screencast and remote desktop portal
2022-03-31 15:30:07 +00:00
desktop_capture_metrics_helper.cc
Add telemetry to measure usage, perf, and errors in Desktop Capturers.
2021-04-13 23:30:52 +00:00
desktop_capture_metrics_helper.h
Add telemetry to measure usage, perf, and errors in Desktop Capturers.
2021-04-13 23:30:52 +00:00
desktop_capture_options.cc
PipeWire capturer: split xdg-desktop-portal and PipeWire implementations
2022-01-21 19:14:37 +00:00
desktop_capture_options.h
getDisplayMedia shows black window on Youtube PiP in Windows.
2022-03-16 22:06:04 +00:00
desktop_capture_types.h
Query the system for WGC support instead of relying on version checks.
2022-04-08 18:16:38 +00:00
desktop_capturer_differ_wrapper_unittest.cc
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
desktop_capturer_differ_wrapper.cc
wayland: Add a common interface for screencast and remote desktop portal
2022-03-31 15:30:07 +00:00
desktop_capturer_differ_wrapper.h
wayland: Add a common interface for screencast and remote desktop portal
2022-03-31 15:30:07 +00:00
desktop_capturer_wrapper.cc
…
desktop_capturer_wrapper.h
…
desktop_capturer.cc
Query the system for WGC support instead of relying on version checks.
2022-04-08 18:16:38 +00:00
desktop_capturer.h
wayland: Add a common interface for screencast and remote desktop portal
2022-03-31 15:30:07 +00:00
desktop_frame_generator.cc
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
desktop_frame_generator.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
desktop_frame_rotation_unittest.cc
…
desktop_frame_rotation.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
desktop_frame_rotation.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
desktop_frame_unittest.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
desktop_frame_win.cc
Handle SharedMemory allocation failures
2021-09-22 23:49:50 +00:00
desktop_frame_win.h
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
desktop_frame.cc
Fix drawing of local mouse in CRD on ChromeOS
2022-04-21 07:53:44 +00:00
desktop_frame.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
desktop_geometry_unittest.cc
…
desktop_geometry.cc
Include menus & dialogs in frames captured by WindowCapturerWin
2019-08-21 07:55:07 +00:00
desktop_geometry.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
desktop_region_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
desktop_region.cc
Use backticks not vertical bars to denote variables in comments
2021-08-10 10:40:03 +00:00
desktop_region.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
differ_block_unittest.cc
…
differ_block.cc
Refactor cpu_features_wrapper.h functions from C to C++.
2020-09-07 08:44:24 +00:00
differ_block.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
differ_vector_sse2.cc
…
differ_vector_sse2.h
…
fake_desktop_capturer.cc
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
fake_desktop_capturer.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
fallback_desktop_capturer_wrapper_unittest.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
fallback_desktop_capturer_wrapper.cc
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
fallback_desktop_capturer_wrapper.h
Revert "Desktop capturer: Add OnDisplayChanged callback"
2018-12-22 00:10:40 +00:00
full_screen_application_handler.cc
Implement handling for MS PowerPoint Presentation Mode.
2019-12-03 19:17:24 +00:00
full_screen_application_handler.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
full_screen_window_detector.cc
Implement handling for MS PowerPoint Presentation Mode.
2019-12-03 19:17:24 +00:00
full_screen_window_detector.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
mock_desktop_capturer_callback.cc
…
mock_desktop_capturer_callback.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
mouse_cursor_monitor_linux.cc
Implement MouseCursorMonitorPipeWire to track cursor changes separately
2022-02-15 23:03:41 +00:00
mouse_cursor_monitor_mac.mm
Initialize last_cursor_
2021-12-09 12:56:11 +00:00
mouse_cursor_monitor_null.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
mouse_cursor_monitor_unittest.cc
Remove all #include <assert.h>/<cassert> and usage in Obj-C code.
2021-07-22 14:00:26 +00:00
mouse_cursor_monitor_win.cc
Remove all #include <assert.h>/<cassert> and usage in Obj-C code.
2021-07-22 14:00:26 +00:00
mouse_cursor_monitor.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
mouse_cursor.cc
Replace assert() with RTC_DCHECK().
2021-07-09 07:49:43 +00:00
mouse_cursor.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
OWNERS
Replace desktop_capture OWNERS
2021-11-09 23:02:32 +00:00
resolution_tracker.cc
…
resolution_tracker.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
rgba_color_unittest.cc
…
rgba_color.cc
Format almost everything.
2019-07-08 13:45:15 +00:00
rgba_color.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
screen_capture_frame_queue.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
screen_capturer_darwin.mm
…
screen_capturer_helper_unittest.cc
Fully qualify googletest symbols.
2019-04-09 17:18:20 +00:00
screen_capturer_helper.cc
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
screen_capturer_helper.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
screen_capturer_integration_test.cc
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
screen_capturer_linux.cc
PipeWire capturer: split xdg-desktop-portal and PipeWire implementations
2022-01-21 19:14:37 +00:00
screen_capturer_mac_unittest.cc
Fully qualify googletest symbols.
2019-04-09 17:18:20 +00:00
screen_capturer_null.cc
…
screen_capturer_unittest.cc
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
screen_capturer_win.cc
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
screen_drawer_linux.cc
Reland "Linux capturers: organize X11 and Wayland implementations into separate folders"
2021-12-14 03:20:34 +00:00
screen_drawer_lock_posix.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
screen_drawer_lock_posix.h
…
screen_drawer_mac.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
screen_drawer_unittest.cc
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
screen_drawer_win.cc
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
screen_drawer.cc
…
screen_drawer.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
shared_desktop_frame.cc
Prepare for deleting implicit conversion from raw pointer to scoped_refptr.
2022-01-18 08:22:15 +00:00
shared_desktop_frame.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
shared_memory.cc
…
shared_memory.h
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
test_utils_unittest.cc
Don't crash the test process when X11 isn't available.
2019-12-16 09:57:59 +00:00
test_utils.cc
…
test_utils.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00
window_capturer_linux.cc
PipeWire capturer: split xdg-desktop-portal and PipeWire implementations
2022-01-21 19:14:37 +00:00
window_capturer_mac.mm
Remove RTC_DISALLOW_COPY_AND_ASSIGN from modules/
2022-01-24 11:50:20 +00:00
window_capturer_null.cc
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
window_capturer_unittest.cc
Temporarily skip tests that consistently fail on Linux MSan.
2021-07-08 08:11:50 +00:00
window_capturer_win.cc
Disallow set_allow_wgc_capturer_fallback call on Win10.
2022-04-15 23:41:16 +00:00
window_finder_mac.h
Remove rtc_base/scoped_ref_ptr.h.
2019-01-25 20:29:58 +00:00
window_finder_mac.mm
Implement handling for MS PowerPoint Presentation Mode.
2019-12-03 19:17:24 +00:00
window_finder_unittest.cc
Reland "Linux capturers: organize X11 and Wayland implementations into separate folders"
2021-12-14 03:20:34 +00:00
window_finder_win.cc
Use std::make_unique instead of absl::make_unique.
2019-09-17 15:47:29 +00:00
window_finder_win.h
…
window_finder.cc
…
window_finder.h
Use backticks not vertical bars to denote variables in comments for /modules/desktop_capture
2021-08-09 13:12:52 +00:00