Henrik Grunell
70294c8eab
Revert "Add ScopedAllowBaseSyncPrimitives for DesktopConfigurationMonitor."
This reverts commit 0a3593c25dbc96b7d66d17ab77fc9984ab2bf245.
Reason for revert: breaks WebRTC roll to Chromium. https://chromium-review.googlesource.com/c/chromium/src/+/894164
[19742:771:0130/150628.286256:FATAL:thread_restrictions.cc(67)] Check failed: !g_blocking_disallowed.Get().Get(). To allow //base sync primitives in a scope where blocking is disallowed use ScopedAllowBaseSyncPrimitivesOutsideBlockingScope.
0 browser_tests 0x0000000108d3682c base::debug::StackTrace::StackTrace(unsigned long) + 28
1 browser_tests 0x0000000108d5b210 logging::LogMessage::~LogMessage() + 224
2 browser_tests 0x0000000108e04366 base::ScopedAllowBaseSyncPrimitives::ScopedAllowBaseSyncPrimitives() + 150
3 browser_tests 0x000000010be59c48 webrtc::DesktopConfigurationMonitor::Lock() + 24
4 browser_tests 0x0000000106dbf229 webrtc::DesktopCapturer::CreateRawScreenCapturer(webrtc::DesktopCaptureOptions const&) + 313
5 browser_tests 0x000000010be58725 webrtc::DesktopCapturer::CreateScreenCapturer(webrtc::DesktopCaptureOptions const&) + 21
6 browser_tests 0x00000001074dc209 content::DesktopCaptureDevice::Create(content::DesktopMediaID const&) + 169
(...)
Original change's description:
> Add ScopedAllowBaseSyncPrimitives for DesktopConfigurationMonitor.
> This is a temporary measure until the synchronization method
> used in the class, gets fixed.
>
> Bug: chromium:796889, chromium:795340
> Change-Id: Ie3d394ae42f005e8e0f353d04ea9c1d053ea9fd2
> Reviewed-on: https://webrtc-review.googlesource.com/40460
> Reviewed-by: Erik Språng <sprang@webrtc.org>
> Commit-Queue: Tommi <tommi@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21812}
TBR=tommi@webrtc.org,sprang@webrtc.org
Change-Id: I6237c3df7e33918d9fe2e46bad0f6f96cda77cd1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:796889, chromium:795340
Reviewed-on: https://webrtc-review.googlesource.com/46540
Reviewed-by: Henrik Grunell <henrikg@webrtc.org>
Commit-Queue: Henrik Grunell <henrikg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21817}
2018-01-31 08:32:19 +00:00
..
2018-01-31 08:32:19 +00:00
2017-11-09 11:56:32 +00:00
2017-11-09 11:56:32 +00:00
2018-01-26 13:34:12 +00:00
2017-09-15 18:56:26 +00:00
2017-09-15 18:56:26 +00:00
2017-11-09 11:56:32 +00:00
2017-11-09 11:56:32 +00:00
2017-12-12 20:01:29 +00:00
2017-09-15 13:03:51 +00:00
2017-09-15 13:03:51 +00:00
2017-09-15 18:56:26 +00:00
2017-09-15 18:56:26 +00:00
2017-11-09 11:56:32 +00:00
2017-09-15 13:03:51 +00:00
2017-09-15 13:03:51 +00:00
2017-09-15 13:03:51 +00:00
2017-09-15 13:03:51 +00:00
2017-09-15 13:03:51 +00:00
2017-11-07 01:49:35 +00:00
2017-11-09 11:56:32 +00:00
2017-11-09 11:56:32 +00:00
2017-09-15 13:03:51 +00:00
2017-09-15 13:03:51 +00:00
2017-11-09 11:56:32 +00:00
2017-12-12 20:01:29 +00:00
2017-11-09 11:56:32 +00:00
2017-11-09 11:56:32 +00:00
2017-11-09 11:56:32 +00:00
2017-11-09 11:56:32 +00:00
2017-10-06 13:00:14 +00:00
2017-09-15 13:03:51 +00:00
2017-11-09 11:56:32 +00:00
2017-10-13 20:34:12 +00:00
2017-11-09 11:56:32 +00:00
2017-11-09 11:56:32 +00:00
2017-11-07 01:49:35 +00:00
2017-11-07 01:49:35 +00:00
2017-11-28 01:21:47 +00:00
2017-11-07 01:49:35 +00:00
2017-11-07 01:49:35 +00:00