admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
webrtc_m130/video
History
Markus Handell e864dec2e9 VSyncEncodeAdapterMode: avoid UAF. 
This CL fixes a problem where VSEAM's `queue_` was dereferenced
post destruction. A sequence triggering it is:

0. FrameCadenceAdapter (FCA) is configured with Metronome with >= 34 ms tick delay.
1. A frame is queued for processing on worker queue.
2. The FCA is destroyed. The contained VSyncEncodeAdapterMode instance is scheduled for deletion on worker queue.
3. Encode queue is destroyed.
4. Worker queue is executed, which runs a task that dereferences `queue_`.

Bug: chromium:356423094
Change-Id: Iae8dc070304ef5ec0cfb0b4f27bbb7fe86e7def7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/358660
Commit-Queue: Markus Handell <handellm@webrtc.org>
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42745}
2024-08-08 11:02:50 +00:00
..
adaptation
Remove unused QpFastFilterLow method
2024-07-31 10:40:42 +00:00
config
Override stream settings in a separate function
2024-07-19 13:59:27 +00:00
end_to_end_tests
Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies
2024-07-29 07:17:14 +00:00
g3doc
Fix video version of RTCInboundRtpStreamStats.jitterBufferDelay to obey spec.
2023-05-25 07:33:39 +00:00
render
Mass removal of absl_deps in all BUILD.gn files
2024-05-23 15:09:46 +00:00
test
pc: Add asynchronous RtpSender::SetParameters() call
2022-11-15 15:31:40 +00:00
alignment_adjuster_unittest.cc
AlignmentAdjuster: take reduced layers into account for default downscaling.
2021-01-19 16:59:11 +00:00
alignment_adjuster.cc
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
alignment_adjuster.h
Move VideoEncoderConfig from api/ into video/config
2022-09-29 09:44:43 +00:00
buffered_frame_decryptor_unittest.cc
Move rtc::make_ref_counted to api/
2022-06-15 09:47:38 +00:00
buffered_frame_decryptor.cc
Move video video receiver transformable frame to modules/rtc_rtcp/source
2023-02-03 12:59:19 +00:00
buffered_frame_decryptor.h
Move video video receiver transformable frame to modules/rtc_rtcp/source
2023-02-03 12:59:19 +00:00
BUILD.gn
Add QualityConvergenceController to VideoStreamEncoder
2024-07-16 10:20:27 +00:00
call_stats2_unittest.cc
In video replace non-owning pointer to rtc::TaskQueue with non-owning pointer to TaskQueueBase
2022-07-18 13:59:32 +00:00
call_stats2.cc
Replace Thread::Invoke with Thread::BlockingCall
2022-09-09 10:44:17 +00:00
call_stats2.h
In video replace non-owning pointer to rtc::TaskQueue with non-owning pointer to TaskQueueBase
2022-07-18 13:59:32 +00:00
cpu_scaling_tests.cc
Reland "Remove dependency of video_replay on TestADM."
2023-04-25 09:39:22 +00:00
decode_synchronizer_unittest.cc
DecodeSynchronizer: avoid duplicate tick callback registration.
2023-04-28 10:50:57 +00:00
decode_synchronizer.cc
DecodeSynchronizer: avoid duplicate tick callback registration.
2023-04-28 10:50:57 +00:00
decode_synchronizer.h
DecodeSynchronizer: avoid duplicate tick callback registration.
2023-04-28 10:50:57 +00:00
DEPS
Delete modules/video_processing
2022-09-30 13:50:49 +00:00
encoder_bitrate_adjuster_unittest.cc
Wire up trial for alternative EncoderBitrateAdjuster behavior.
2024-07-05 13:36:26 +00:00
encoder_bitrate_adjuster.cc
Default enable new bitrate adjuster behavior.
2024-07-09 06:30:13 +00:00
encoder_bitrate_adjuster.h
Wire up trial for alternative EncoderBitrateAdjuster behavior.
2024-07-05 13:36:26 +00:00
encoder_overshoot_detector_unittest.cc
Remove multiplex codec.
2024-02-26 11:26:04 +00:00
encoder_overshoot_detector.cc
Remove multiplex codec.
2024-02-26 11:26:04 +00:00
encoder_overshoot_detector.h
Video: add new metric for VP9/AV1 hw encoding with softwareBRC
2023-04-20 12:54:06 +00:00
encoder_rtcp_feedback_unittest.cc
Query WebRTC-KeyframeInterval through propagated field trials
2024-05-20 13:37:24 +00:00
encoder_rtcp_feedback.cc
Query WebRTC-KeyframeInterval through propagated field trials
2024-05-20 13:37:24 +00:00
encoder_rtcp_feedback.h
Query WebRTC-KeyframeInterval through propagated field trials
2024-05-20 13:37:24 +00:00
frame_cadence_adapter_unittest.cc
VSyncEncodeAdapterMode: avoid UAF.
2024-08-08 11:02:50 +00:00
frame_cadence_adapter.cc
VSyncEncodeAdapterMode: avoid UAF.
2024-08-08 11:02:50 +00:00
frame_cadence_adapter.h
Reland "FrameCadenceAdapter keep track of Input framerate"
2024-03-27 12:58:03 +00:00
frame_decode_scheduler.h
Clean up FrameDecodeScheduler
2022-09-06 08:24:48 +00:00
frame_decode_timing_unittest.cc
Cap max decode delay for FrameBuffer3
2022-06-13 14:52:46 +00:00
frame_decode_timing.cc
Cap FrameBuffer3 max wait based on remaining timeout
2022-06-23 09:03:46 +00:00
frame_decode_timing.h
Move to_queued_task.h and pending_task_safety_flag.h into public API
2022-06-17 09:20:39 +00:00
frame_dumping_decoder.cc
Remove EncodedFrame::MissingFrame and start removing Decode() param
2023-08-30 10:38:35 +00:00
frame_dumping_decoder.h
…
frame_dumping_encoder.cc
FrameDumpingEncoder: relax threading assumptions.
2023-08-23 12:58:58 +00:00
frame_dumping_encoder.h
Introduce a frame dumping encoder wrapper.
2023-08-22 15:45:32 +00:00
frame_encode_metadata_writer_unittest.cc
Set is_steady_state_refresh_frame in FrameEncodeMetadataWriter
2024-06-27 11:58:13 +00:00
frame_encode_metadata_writer.cc
Remove deprecated function FillTimingInfo()
2024-07-09 23:23:55 +00:00
frame_encode_metadata_writer.h
Remove deprecated function FillTimingInfo()
2024-07-09 23:23:55 +00:00
full_stack_tests_plot.py
Reformat python files checked by pylint (part 1/2).
2020-10-30 10:13:11 +00:00
full_stack_tests.cc
Disable AV1 screencast test on Mac
2024-07-08 07:33:48 +00:00
OWNERS
Add ssilkin@webrtc to OWNERS in video/
2024-07-15 09:11:54 +00:00
pc_full_stack_tests.cc
Reland "Replace usage of link_capacity_kbps with DataRate link_capacity"
2024-05-16 10:39:10 +00:00
picture_id_tests.cc
Move call/simulated_network to test/network
2024-04-29 09:55:06 +00:00
quality_convergence_controller_unittest.cc
Add QualityConvergenceController to VideoStreamEncoder
2024-07-16 10:20:27 +00:00
quality_convergence_controller.cc
Add QualityConvergenceController to VideoStreamEncoder
2024-07-16 10:20:27 +00:00
quality_convergence_controller.h
Add QualityConvergenceController to VideoStreamEncoder
2024-07-16 10:20:27 +00:00
quality_convergence_monitor_unittest.cc
Add default values and field trials to QualityConvergenceMonitor
2024-07-01 22:37:46 +00:00
quality_convergence_monitor.cc
Add default values and field trials to QualityConvergenceMonitor
2024-07-01 22:37:46 +00:00
quality_convergence_monitor.h
Add default values and field trials to QualityConvergenceMonitor
2024-07-01 22:37:46 +00:00
quality_limitation_reason_tracker_unittest.cc
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
quality_limitation_reason_tracker.cc
…
quality_limitation_reason_tracker.h
stats: convert qualitylimitationdurations to seconds
2022-01-11 10:58:35 +00:00
quality_scaling_tests.cc
Clean up EncoderStreamFactory
2024-07-09 09:47:55 +00:00
rate_utilization_tracker_unittest.cc
Default enable new bitrate adjuster behavior.
2024-07-09 06:30:13 +00:00
rate_utilization_tracker.cc
Default enable new bitrate adjuster behavior.
2024-07-09 06:30:13 +00:00
rate_utilization_tracker.h
Add rate utilization tracker helper class.
2024-07-04 17:47:38 +00:00
receive_statistics_proxy_unittest.cc
Deprecate VideoFrame::timestamp() and set_timestamp
2024-03-13 11:08:37 +00:00
receive_statistics_proxy.cc
Reland "Fix definition of keyframes decoded statistics"
2023-08-15 12:09:46 +00:00
receive_statistics_proxy.h
Reland "Fix definition of keyframes decoded statistics"
2023-08-15 12:09:46 +00:00
report_block_stats_unittest.cc
Remove redundant VideoSendStream::rtcp_stats field
2021-05-18 13:37:51 +00:00
report_block_stats.cc
Remove redundant VideoSendStream::rtcp_stats field
2021-05-18 13:37:51 +00:00
report_block_stats.h
Remove redundant VideoSendStream::rtcp_stats field
2021-05-18 13:37:51 +00:00
rtp_streams_synchronizer2.cc
Cleanup RtpToNtpEstimator
2022-03-17 10:26:57 +00:00
rtp_streams_synchronizer2.h
In video replace non-owning pointer to rtc::TaskQueue with non-owning pointer to TaskQueueBase
2022-07-18 13:59:32 +00:00
rtp_video_stream_receiver2_unittest.cc
Remove kMaxNalusPerPacket hard limit for H264 frames
2024-06-14 16:29:42 +00:00
rtp_video_stream_receiver2.cc
In RtpVideoStreamReceiver do not rely on RTP sequence number unwrap to be stable
2024-07-22 15:42:12 +00:00
rtp_video_stream_receiver2.h
stats: implement remote-outbound-rtp for video
2024-04-15 15:10:54 +00:00
screenshare_loopback.cc
Fix default link capacity in standalone loopback tests
2024-06-13 13:46:49 +00:00
send_delay_stats_unittest.cc
Removed unneeded inheritence for SendDelayStats class
2023-09-08 17:53:27 +00:00
send_delay_stats.cc
Cleanup usage of lookups in video SendDelayStats helper
2023-08-25 16:55:23 +00:00
send_delay_stats.h
Removed unneeded inheritence for SendDelayStats class
2023-09-08 17:53:27 +00:00
send_statistics_proxy_unittest.cc
Rename EncodedImage property Timetamp to RtpTimestamp
2023-09-24 20:06:48 +00:00
send_statistics_proxy.cc
VideoStreamEncoder: Clean up drop handling and update rects.
2023-11-23 17:19:33 +00:00
send_statistics_proxy.h
Delete SendDelayObserver interface
2023-09-15 14:59:23 +00:00
stats_counter_unittest.cc
…
stats_counter.cc
Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED
2021-11-15 21:44:59 +00:00
stats_counter.h
Reland "Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely"
2022-01-27 12:55:44 +00:00
stream_synchronization_unittest.cc
Cleanup RtpToNtpEstimator
2022-03-17 10:26:57 +00:00
stream_synchronization.cc
Cleanup RtpToNtpEstimator
2022-03-17 10:26:57 +00:00
stream_synchronization.h
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
sv_loopback.cc
Fix default link capacity in standalone loopback tests
2024-06-13 13:46:49 +00:00
task_queue_frame_decode_scheduler_unittest.cc
Clean up FrameDecodeScheduler
2022-09-06 08:24:48 +00:00
task_queue_frame_decode_scheduler.cc
Ensure video frame buffer is still decodable before decoding
2022-10-28 13:07:40 +00:00
task_queue_frame_decode_scheduler.h
Introduce Sync-Decoding based on Metronome
2022-02-14 11:14:00 +00:00
transport_adapter.cc
Use ArrayView versions of SendRtp and SendRtcp
2023-08-07 08:28:48 +00:00
transport_adapter.h
Use ArrayView versions of SendRtp and SendRtcp
2023-08-07 08:28:48 +00:00
unique_timestamp_counter_unittest.cc
Move UniqueTimestampCounter to video/
2022-05-23 13:21:32 +00:00
unique_timestamp_counter.cc
Move UniqueTimestampCounter to video/
2022-05-23 13:21:32 +00:00
unique_timestamp_counter.h
Move UniqueTimestampCounter to video/
2022-05-23 13:21:32 +00:00
video_analyzer.cc
Deprecate VideoFrame::timestamp() and set_timestamp
2024-03-13 11:08:37 +00:00
video_analyzer.h
Remove internal overrides using old SendRtp and SendRtcp interfaces.
2023-08-15 13:20:21 +00:00
video_loopback_main.cc
…
video_loopback_main.mm
…
video_loopback.cc
Fix default link capacity in standalone loopback tests
2024-06-13 13:46:49 +00:00
video_loopback.h
…
video_quality_observer2.cc
Remove WebRTC.Video.Screenshare.NUmberResolutionDownswitchesPerMinute histogram
2022-12-08 11:04:15 +00:00
video_quality_observer2.h
Use backticks not vertical bars to denote variables in comments for /video
2021-07-28 13:22:27 +00:00
video_quality_test.cc
Allow supplying a custom NetworkControllerInterfaceFactory per-Call in PeerConnectionDependencies
2024-07-29 07:17:14 +00:00
video_quality_test.h
In EncoderStreamFactory pass field trials as required parameter
2024-04-17 12:53:30 +00:00
video_receive_stream2_unittest.cc
Remove more sstream deps
2024-07-09 10:30:26 +00:00
video_receive_stream2.cc
In RtpVideoStreamReceiver do not rely on RTP sequence number unwrap to be stable
2024-07-22 15:42:12 +00:00
video_receive_stream2.h
Log last decoded frame rtp timestamp
2024-07-05 15:41:33 +00:00
video_receive_stream_timeout_tracker_unittest.cc
Video stream timeout tracker returns the total delay
2022-06-16 13:46:20 +00:00
video_receive_stream_timeout_tracker.cc
Make nack history configurable.
2022-08-05 22:58:43 +00:00
video_receive_stream_timeout_tracker.h
Make nack history configurable.
2022-08-05 22:58:43 +00:00
video_send_stream_impl_unittest.cc
Add variables to lend unused audio bits to video
2024-07-30 18:42:16 +00:00
video_send_stream_impl.cc
Add variables to lend unused audio bits to video
2024-07-30 18:42:16 +00:00
video_send_stream_impl.h
Add variables to lend unused audio bits to video
2024-07-30 18:42:16 +00:00
video_send_stream_tests.cc
Clean up EncoderStreamFactory
2024-07-09 09:47:55 +00:00
video_source_sink_controller_unittest.cc
Reland "RtpEncodingParameters::request_resolution patch 1"
2022-09-23 11:48:19 +00:00
video_source_sink_controller.cc
Reland "RtpEncodingParameters::request_resolution patch 1"
2022-09-23 11:48:19 +00:00
video_source_sink_controller.h
Reland "RtpEncodingParameters::request_resolution patch 1"
2022-09-23 11:48:19 +00:00
video_stream_buffer_controller_unittest.cc
Rename EncodedImage property Timetamp to RtpTimestamp
2023-09-24 20:06:48 +00:00
video_stream_buffer_controller.cc
Cleanup RttMult experiment as launched
2024-04-02 08:22:55 +00:00
video_stream_buffer_controller.h
Cleanup RttMult experiment as launched
2024-04-02 08:22:55 +00:00
video_stream_decoder2.cc
Reland "Fix definition of keyframes decoded statistics"
2023-08-15 12:09:46 +00:00
video_stream_decoder2.h
Reland "Fix definition of keyframes decoded statistics"
2023-08-15 12:09:46 +00:00
video_stream_decoder_impl_unittest.cc
Introduce "well-known" SdpVideoFormat codecs
2024-02-28 06:57:10 +00:00
video_stream_encoder_interface.h
pc: Add asynchronous RtpSender::SetParameters() call
2022-11-15 15:31:40 +00:00
video_stream_encoder_observer.h
VideoStreamEncoder: Clean up drop handling and update rects.
2023-11-23 17:19:33 +00:00
video_stream_encoder_unittest.cc
Reland "Pass true stream resolutions to GetSimulcastConfig()"
2024-07-19 13:12:59 +00:00
video_stream_encoder.cc
Add QualityConvergenceController to VideoStreamEncoder
2024-07-16 10:20:27 +00:00
video_stream_encoder.h
Add QualityConvergenceController to VideoStreamEncoder
2024-07-16 10:20:27 +00:00