25702cb162
* Better param names * Avoid using negative values for (bogus) placeholder channel counts (mostly in tests). Since channels will be changing to size_t, negative values will be illegal; it's sufficient to use 0 in these cases. * Use arraysize() * Use size_t for counting frames, samples, blocks, buffers, and bytes -- most of these are already size_t in most places, this just fixes some stragglers * reinterpret_cast<int64_t>(void*) is not necessarily safe; use uintptr_t instead * Remove unnecessary code, e.g. dead code, needlessly long/repetitive code, or function overrides that exactly match the base definition * Fix indenting * Use uint32_t for timestamps (matching how it's already a uint32_t in most places) * Spelling * RTC_CHECK_EQ(expected, actual) * Rewrap * Use .empty() * Be more pedantic about matching int/int32_t/ * Remove pointless consts on input parameters to functions * Add missing sanity checks All this was found in the course of constructing https://codereview.webrtc.org/1316523002/ , and is being landed separately first. BUG=none TEST=none Review URL: https://codereview.webrtc.org/1534193008 Cr-Commit-Position: refs/heads/master@{#11191}
INSTRUCTIONS: - Start with test #3 (Device enumeration) to get an overview of the available audio devices. - Next, proceed with test #4 (Device selection) to get more details about the supported functions for each audio device. - Verify two-way audio in test #5. Repeat this test for different selections of playout and recording devices. - More detailed tests (volume, mute etc.) can also be performed using #6-#11. NOTE: - Some tests requires that the user opens up the audio mixer dialog and verifies that a certain action (e.g. Mute ON/OFF) is executed correctly. - Files can be recorded during some tests to enable off-line analysis. - Full support of 'Default Communication' devices requires Windows 7. - If a test consists of several sub tests, press any key to start a new sub test. KNOWN ISSUES: - Microphone Boost control is not supported on Windows Vista or Windows 7. - Speaker and microphone volume controls will not work as intended on Windows Vista if a 'Default Communication' device is selected in any direction.