d81dc49c5b
VS 2015 has a new or louder warning about 32-bit shifts that are then assigned to a 64-bit target. This type of code triggers it: int64_t size = 1 << shift_amount; Because the '1' being shifted is a 32-bit int the result of the shift will be a 32-bit result, so assigning it to a 64-bit variable is just misleading. In this case the code that triggers it is this: size_t window_size = static_cast<size_t>(1 << shift_amount); The destination is a size_t so the warning only shows up on 64-bit builds and doesn't indicate a real bug. It's curious that the code had a cast already - presumably to suppress some other warning - but the cast is not in the ideal place and doesn't avoid this new warning. Moving the cast allows shift_amount to be log2(size_t) and allows enabling C4334 in Chromium. BUG=593448 Review URL: https://codereview.webrtc.org/1849753004 Cr-Commit-Position: refs/heads/master@{#12199}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://chromium.googlesource.com/external/webrtc
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc