This reverts commit 1cfeb435427a2fa677a495e34c882096efc193d0. Reason for revert: Fix unit test Original change's description: > Revert "Revert "Revert "Support more formats in RTCVideoFrame""" > > This reverts commit 7583390d1a3a7c4e9a77da0d77250abac0c34d1d. > > Reason for revert: Breaks unit tests > > Original change's description: > > Revert "Revert "Support more formats in RTCVideoFrame"" > > > > This reverts commit 0789dab2cbd1617e94d7300e375163d42345f3d4. > > > > Reason for revert: Include obc_corevideoframebuffer target > > > > Original change's description: > > > Revert "Support more formats in RTCVideoFrame" > > > > > > This reverts commit bd2220a9c496ef2e8567b68d4be9435a110bdc34. > > > > > > Reason for revert: Broke external clients > > > > > > Original change's description: > > > > Support more formats in RTCVideoFrame > > > > > > > > Implement Obj-C version of webrtc::VideoFrameBuffer and use that in > > > > RTCVideoFrame. > > > > > > > > Bug: webrtc:7785 > > > > Change-Id: I49f42bcf451dd6769b3a79a65fe7b400dce22677 > > > > Reviewed-on: https://chromium-review.googlesource.com/536773 > > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > > Reviewed-by: Magnus Jedvert <magjed@webrtc.org> > > > > Cr-Commit-Position: refs/heads/master@{#18691} > > > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > > > Change-Id: Id765dd9543ed0613a6b2de108b268c3501025fcd > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:7785 > > > Reviewed-on: https://chromium-review.googlesource.com/542837 > > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > > Cr-Commit-Position: refs/heads/master@{#18697} > > > > TBR=magjed@webrtc.org,andersc@webrtc.org > > > > Change-Id: I1ef5313b4a6c56eb8c7fd02d95db62c4e3c00255 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: webrtc:7785 > > Reviewed-on: https://chromium-review.googlesource.com/542838 > > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#18716} > > TBR=magjed@webrtc.org,andersc@webrtc.org > > Change-Id: Id12f33698eb02041607cb9a5c54f37f01bfac5b1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:7785 > Reviewed-on: https://chromium-review.googlesource.com/544840 > Reviewed-by: Anders Carlsson <andersc@webrtc.org> > Commit-Queue: Anders Carlsson <andersc@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#18718} TBR=magjed@webrtc.org,andersc@webrtc.org Change-Id: I184303ecba8db91ef7de709f982a295a2efe92eb Bug: webrtc:7785 Reviewed-on: https://chromium-review.googlesource.com/544841 Commit-Queue: Magnus Jedvert <magjed@webrtc.org> Reviewed-by: Anders Carlsson <andersc@webrtc.org> Cr-Commit-Position: refs/heads/master@{#18731}
198 lines
5.8 KiB
Plaintext
198 lines
5.8 KiB
Plaintext
/*
|
|
* Copyright 2017 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#import <Foundation/Foundation.h>
|
|
#import <OCMock/OCMock.h>
|
|
|
|
#include "webrtc/base/gunit.h"
|
|
|
|
#include <Metal/RTCMTLNV12Renderer.h>
|
|
#include <WebRTC/RTCMTLVideoView.h>
|
|
#include <WebRTC/RTCVideoFrameBuffer.h>
|
|
|
|
// Extension of RTCMTLVideoView for testing purposes.
|
|
@interface RTCMTLVideoView (Testing)
|
|
|
|
+ (BOOL)isMetalAvailable;
|
|
+ (UIView*)createMetalView:(CGRect)frame;
|
|
+ (id<RTCMTLRenderer>)createNV12Renderer;
|
|
+ (id<RTCMTLRenderer>)createI420Renderer;
|
|
- (void)drawInMTKView:(id)view;
|
|
@end
|
|
|
|
@interface RTCMTLVideoViewTests : NSObject
|
|
@property(nonatomic, strong) id classMock;
|
|
@property(nonatomic, strong) id metalViewMock;
|
|
@property(nonatomic, strong) id rendererNV12Mock;
|
|
@property(nonatomic, strong) id rendererI420Mock;
|
|
@property(nonatomic, strong) id frameMock;
|
|
@end
|
|
|
|
@implementation RTCMTLVideoViewTests
|
|
|
|
@synthesize classMock = _classMock;
|
|
@synthesize metalViewMock = _metalViewMock;
|
|
@synthesize rendererNV12Mock = _rendererNV12Mock;
|
|
@synthesize rendererI420Mock = _rendererI420Mock;
|
|
@synthesize frameMock = _frameMock;
|
|
|
|
- (void)setup {
|
|
self.classMock = OCMClassMock([RTCMTLVideoView class]);
|
|
}
|
|
|
|
- (void)tearDown {
|
|
[self.classMock stopMocking];
|
|
[self.rendererI420Mock stopMocking];
|
|
[self.rendererNV12Mock stopMocking];
|
|
[self.metalViewMock stopMocking];
|
|
[self.frameMock stopMocking];
|
|
self.classMock = nil;
|
|
self.rendererI420Mock = nil;
|
|
self.rendererNV12Mock = nil;
|
|
self.metalViewMock = nil;
|
|
self.frameMock = nil;
|
|
}
|
|
|
|
- (id)frameMockWithCVPixelBuffer:(BOOL)hasCVPixelBuffer {
|
|
id frameMock = OCMClassMock([RTCVideoFrame class]);
|
|
if (hasCVPixelBuffer) {
|
|
CVPixelBufferRef pixelBufferRef;
|
|
CVPixelBufferCreate(kCFAllocatorDefault,
|
|
200,
|
|
200,
|
|
kCVPixelFormatType_420YpCbCr8Planar,
|
|
nullptr,
|
|
&pixelBufferRef);
|
|
OCMStub([frameMock buffer])
|
|
.andReturn([[RTCCVPixelBuffer alloc] initWithPixelBuffer:pixelBufferRef]);
|
|
} else {
|
|
OCMStub([frameMock buffer]).andReturn([[RTCI420Buffer alloc] initWithWidth:200 height:200]);
|
|
}
|
|
return frameMock;
|
|
}
|
|
|
|
- (id)rendererMockWithSuccessfulSetup:(BOOL)sucess {
|
|
id rendererMock = OCMProtocolMock(@protocol(RTCMTLRenderer));
|
|
OCMStub([rendererMock addRenderingDestination:[OCMArg any]]).andReturn(sucess);
|
|
|
|
return rendererMock;
|
|
}
|
|
|
|
#pragma mark - Test cases
|
|
- (void)testInitAssertsIfMetalUnavailabe {
|
|
// given
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(NO);
|
|
|
|
// when
|
|
BOOL asserts = NO;
|
|
@try {
|
|
RTCMTLVideoView *realView = [[RTCMTLVideoView alloc] initWithFrame:CGRectZero];
|
|
(void)realView;
|
|
} @catch (NSException *ex) {
|
|
asserts = YES;
|
|
}
|
|
|
|
EXPECT_TRUE(asserts);
|
|
}
|
|
|
|
- (void)testRTCVideoRenderNilFrameCallback {
|
|
// given
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
RTCMTLVideoView *realView = [[RTCMTLVideoView alloc] init];
|
|
self.frameMock = OCMClassMock([RTCVideoFrame class]);
|
|
|
|
[[self.frameMock reject] buffer];
|
|
[[self.classMock reject] createNV12Renderer];
|
|
[[self.classMock reject] createI420Renderer];
|
|
|
|
// when
|
|
[realView renderFrame:nil];
|
|
[realView drawInMTKView:self.metalViewMock];
|
|
|
|
// then
|
|
[self.frameMock verify];
|
|
[self.classMock verify];
|
|
}
|
|
|
|
- (void)testRTCVideoRenderFrameCallbackI420 {
|
|
// given
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
self.rendererI420Mock = [self rendererMockWithSuccessfulSetup:YES];
|
|
self.frameMock = [self frameMockWithCVPixelBuffer:NO];
|
|
|
|
OCMExpect([self.rendererI420Mock drawFrame:self.frameMock]);
|
|
OCMExpect([self.classMock createI420Renderer]).andReturn(self.rendererI420Mock);
|
|
[[self.classMock reject] createNV12Renderer];
|
|
|
|
RTCMTLVideoView *realView = [[RTCMTLVideoView alloc] init];
|
|
|
|
// when
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:self.metalViewMock];
|
|
|
|
// then
|
|
[self.rendererI420Mock verify];
|
|
[self.classMock verify];
|
|
}
|
|
|
|
- (void)testRTCVideoRenderFrameCallbackNV12 {
|
|
// given
|
|
OCMStub([self.classMock isMetalAvailable]).andReturn(YES);
|
|
self.rendererNV12Mock = [self rendererMockWithSuccessfulSetup:YES];
|
|
self.frameMock = [self frameMockWithCVPixelBuffer:YES];
|
|
|
|
OCMExpect([self.rendererNV12Mock drawFrame:self.frameMock]);
|
|
OCMExpect([self.classMock createNV12Renderer]).andReturn(self.rendererNV12Mock);
|
|
[[self.classMock reject] createI420Renderer];
|
|
|
|
RTCMTLVideoView *realView = [[RTCMTLVideoView alloc] init];
|
|
|
|
// when
|
|
[realView renderFrame:self.frameMock];
|
|
[realView drawInMTKView:self.metalViewMock];
|
|
|
|
// then
|
|
[self.rendererNV12Mock verify];
|
|
[self.classMock verify];
|
|
}
|
|
@end
|
|
|
|
TEST(RTCMTLVideoViewTests, InitAssertsIfMetalUnavailabe) {
|
|
RTCMTLVideoViewTests *test = [[RTCMTLVideoViewTests alloc] init];
|
|
[test setup];
|
|
|
|
[test testInitAssertsIfMetalUnavailabe];
|
|
[test tearDown];
|
|
}
|
|
|
|
TEST(RTCMTLVideoViewTests, RTCVideoRenderNilFrameCallback) {
|
|
RTCMTLVideoViewTests *test = [[RTCMTLVideoViewTests alloc] init];
|
|
[test setup];
|
|
[test testRTCVideoRenderNilFrameCallback];
|
|
[test tearDown];
|
|
}
|
|
|
|
TEST(RTCMTLVideoViewTests, RTCVideoRenderFrameCallbackI420) {
|
|
RTCMTLVideoViewTests *test = [[RTCMTLVideoViewTests alloc] init];
|
|
[test setup];
|
|
|
|
[test testRTCVideoRenderFrameCallbackI420];
|
|
[test tearDown];
|
|
}
|
|
|
|
// The test is disabled because of frequent crashes. See bugs.webrtc.org/7863
|
|
TEST(RTCMTLVideoViewTests, DISABLED_RTCVideoRenderFrameCallbackNV12) {
|
|
RTCMTLVideoViewTests *test = [[RTCMTLVideoViewTests alloc] init];
|
|
[test setup];
|
|
|
|
[test testRTCVideoRenderFrameCallbackNV12];
|
|
[test tearDown];
|
|
}
|