Evan Shrubsole
e32ae4f8fb
Invalidate encoder rates on VideoStreamEncoder::ReconfigureEncoder ...
Without invalidation the codec configuration may not get updated. This
is prone to happen when the bandwidth is below the min or above the max
in which case the last_encoder_rate_settings_ may have not changed.
This led to a regression in b6a45dd, where last_encoder_rate_settings_
would not change the allocation or frame rate, but the frame rate would
have been set by the video adapter. Thus the frame rates were set
incorrectly, leading to lower values in the regression tests.
I have re-run this scenario against some of the metric drops and the
regression appears to be fixed.
Bug: webrtc:10126
Change-Id: I0fa6c9b71e7aff5dd80e53119db109d97eed98b6
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/154343
Commit-Queue: Evan Shrubsole <eshr@google.com>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29301}
2019-09-25 11:37:52 +00:00
2019-09-25 08:15:20 +00:00
2019-09-09 15:06:51 +00:00
2019-09-23 13:28:09 +00:00
2019-04-09 20:08:56 +00:00
2019-09-24 08:22:38 +00:00
2019-09-25 08:43:24 +00:00
2019-08-06 08:46:48 +00:00
2019-08-09 11:43:16 +00:00
2019-09-24 08:22:38 +00:00
2019-01-11 17:11:39 +00:00
2019-04-09 08:18:20 +00:00
2019-09-17 15:47:29 +00:00
2019-09-17 15:47:29 +00:00
2019-04-15 15:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-04-01 13:10:49 +00:00
2019-04-01 13:10:49 +00:00
2019-04-09 17:18:20 +00:00
2019-04-10 15:31:53 +00:00
2019-09-13 10:49:56 +00:00
2019-09-17 15:47:29 +00:00
2019-08-21 09:49:02 +00:00
2019-06-20 10:24:29 +00:00
2019-09-17 15:47:29 +00:00
2019-06-20 10:24:29 +00:00
2018-07-23 15:28:48 +00:00
2019-09-17 15:47:29 +00:00
2019-09-17 15:47:29 +00:00
2019-09-17 15:47:29 +00:00
2019-04-25 09:26:04 +00:00
2018-09-11 12:39:39 +00:00
2019-09-17 15:47:29 +00:00
2019-09-17 15:47:29 +00:00
2019-05-28 16:23:55 +00:00
2019-05-28 16:23:55 +00:00
2019-09-09 15:22:57 +00:00
2019-03-11 13:37:38 +00:00
2018-11-28 18:25:07 +00:00
2018-08-29 11:57:00 +00:00
2019-08-27 07:43:01 +00:00
2019-08-28 06:56:12 +00:00
2019-09-24 08:22:38 +00:00
2019-08-02 08:58:36 +00:00
2019-08-01 14:09:23 +00:00
2019-08-01 14:09:23 +00:00
2019-04-08 16:58:07 +00:00
2019-01-11 17:11:39 +00:00
2019-09-24 08:56:24 +00:00
2019-09-23 13:28:09 +00:00
2019-09-23 13:28:09 +00:00
2019-09-18 06:37:58 +00:00
2018-11-28 18:25:07 +00:00
2017-11-09 11:56:32 +00:00
2019-07-08 13:45:15 +00:00
2019-09-09 15:22:57 +00:00
2019-09-09 15:22:57 +00:00
2019-09-09 15:22:57 +00:00
2018-06-19 14:00:39 +00:00
2018-09-24 09:39:19 +00:00
2019-01-11 17:11:39 +00:00
2019-07-08 13:45:15 +00:00
2019-07-08 13:45:15 +00:00
2018-11-28 18:25:07 +00:00
2019-09-18 06:37:58 +00:00
2018-08-29 11:57:00 +00:00
2019-07-08 13:45:15 +00:00
2019-09-24 08:25:44 +00:00
2019-09-24 08:25:44 +00:00
2019-03-06 14:37:33 +00:00
2019-03-06 14:37:33 +00:00
2019-09-18 06:37:58 +00:00
2019-03-06 14:37:33 +00:00
2019-08-26 12:57:59 +00:00
2019-08-02 12:38:34 +00:00
2019-09-17 15:47:29 +00:00
2019-07-08 13:45:15 +00:00
2019-09-17 15:47:29 +00:00
2019-09-17 19:43:05 +00:00
2019-09-13 10:49:56 +00:00
2019-09-17 15:47:29 +00:00
2019-09-17 15:47:29 +00:00
2019-09-09 15:06:51 +00:00
2019-08-07 10:58:17 +00:00
2019-09-17 15:47:29 +00:00
2019-03-14 08:51:49 +00:00
2019-03-29 18:53:27 +00:00
2019-09-17 15:47:29 +00:00
2019-06-05 11:58:57 +00:00
2019-09-09 11:23:54 +00:00
2019-09-09 11:23:54 +00:00
2019-09-25 11:37:52 +00:00
2019-09-25 11:37:52 +00:00
2019-09-18 14:38:15 +00:00
e32ae4f8fb