d49c30cd2f
Reason for revert: Speculative revert to see if failures on the DrMemory bot are related to this cl. See e.g. here: https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Full/builds/4243 UNINITIALIZED READ: reading 0x04980040-0x04980060 32 byte(s) within 0x04980040-0x04980060 # 0 CopyRow_AVX # 1 CopyPlane # 2 I420Copy # 3 webrtc::ExtractBuffer # 4 cricket::WebRtcVideoCapturer::SignalFrameCapturedOnStartThread # 5 cricket::WebRtcVideoCapturer::OnIncomingCapturedFrame # 6 FakeWebRtcVideoCaptureModule::SendFrame # 7 WebRtcVideoCapturerTest_TestCaptureVcm_Test::TestBody # 8 testing::internal::HandleSehExceptionsInMethodIfSupported<> Original issue's description: > Reland of Delete webrtc::VideoFrame methods buffer and stride. (patchset #1 id:1 of https://codereview.webrtc.org/1935443002/ ) > > Reason for revert: > I plan to reland this change in a week or two, after downstream users are updated. > > Original issue's description: > > Revert of Delete webrtc::VideoFrame methods buffer and stride. (patchset #14 id:250001 of https://codereview.webrtc.org/1900673002/ ) > > > > Reason for revert: > > Breaks chrome FYI bots. > > > > Original issue's description: > > > Delete webrtc::VideoFrame methods buffer and stride. > > > > > > To make the HasOneRef/IsMutable hack work, also had to change the > > > video_frame_buffer method to return a const ref to a scoped_ref_ptr, > > > to not imply an AddRef. > > > > > > BUG=webrtc:5682 > > > > TBR=perkj@webrtc.org,magjed@webrtc.org,pbos@webrtc.org,pthatcher@webrtc.org,stefan@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/5b3c443d301f2c2f18dac5b02652c08b91ea3828 > > Cr-Commit-Position: refs/heads/master@{#12558} > > TBR=perkj@webrtc.org,magjed@webrtc.org,pbos@webrtc.org,pthatcher@webrtc.org,stefan@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:5682 > > Committed: https://crrev.com/d0dc66e0ea30c8614001e425a4ae0aa7dd56c2a7 > Cr-Commit-Position: refs/heads/master@{#12721} TBR=perkj@webrtc.org,magjed@webrtc.org,pbos@webrtc.org,pthatcher@webrtc.org,stefan@webrtc.org,nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5682 Review-Url: https://codereview.webrtc.org/1983583002 Cr-Commit-Position: refs/heads/master@{#12745}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
Development
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://chromium.googlesource.com/external/webrtc
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: http://build.chromium.org/p/client.webrtc