c24b6b7815
Add a new frame interface to be used by frame transformers in Insertable Streams. TransformableFrameInterface will replace video_coding::EncodedFrame in a follow up CL, once downstream dependecies are updated to use the new interface. Until the functions using video_coding::EncodedFrame are removed from the API, the video sender and receiver frame transformer delegates call both function versions to avoid breaking tests downstream. The TransformableFrameInterface will be used for both audio and video frame transformers in follow-up CLs. Bug: webrtc:11380 Change-Id: I9389a8549c156e13b1d8c938ff51eaa69c502f33 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171863 Commit-Queue: Marina Ciocea <marinaciocea@webrtc.org> Reviewed-by: Magnus Flodman <mflodman@webrtc.org> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30941}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.