1fee69cfff
This reverts commit 54be7084e0861a0179a5fccd0b27edf7d7994bbb.
Reason for revert: Breaks downstream project.
Original change's description:
> [Stats] Attribute::ToString(), to replace member ValueToString/ToJson.
>
> Delete RTCStatsMember<T>::ValueToString() and ValueToJson() in favor of
> Attribute::ToString().
>
> The difference between "ToString" and "ToJson" is that the "ToJson"
> version converts 64-bit integers and doubles to floating points with no
> more than ~15 digits of precision as to not exceed JSON's precision
> limitations. So only in edge cases of really large numbers or numbers
> with a silly number of digits will the two methods produce different
> results. Also JSON puts '\"' around map key names, e.g. "{\"foo\":123}"
> as opposed to "{foo:123}".
>
> Going forward we see no reason to maintain two different string
> converted paths that are this similar, so we only implement one
> Attribute::ToString() method which does what "ToJson" did.
>
> In the next CL we can delete RTCStatsMember<T>.
>
> Bug: webrtc:15164
> Change-Id: Iaa8cf3bf14b40dc44664f75989832469603131c5
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334640
> Commit-Queue: Henrik Boström <hbos@webrtc.org>
> Reviewed-by: Evan Shrubsole <eshr@google.com>
> Reviewed-by: Harald Alvestrand <hta@webrtc.org>
> Cr-Commit-Position: refs/heads/main@{#41544}
Bug: webrtc:15164
Change-Id: I187d7dff6f330a4a440279e6c32d88eb6ddefac8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334820
Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41546}
95 lines
2.5 KiB
C++
95 lines
2.5 KiB
C++
/*
|
|
* Copyright 2024 The WebRTC Project Authors. All rights reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "api/stats/attribute.h"
|
|
|
|
#include "absl/types/variant.h"
|
|
#include "rtc_base/checks.h"
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
|
|
struct VisitIsSequence {
|
|
// Any type of vector is a sequence.
|
|
template <typename T>
|
|
bool operator()(const RTCStatsMember<std::vector<T>>* attribute) {
|
|
return true;
|
|
}
|
|
// Any other type is not.
|
|
template <typename T>
|
|
bool operator()(const RTCStatsMember<T>* attribute) {
|
|
return false;
|
|
}
|
|
};
|
|
|
|
struct VisitIsEqual {
|
|
template <typename T>
|
|
bool operator()(const RTCStatsMember<T>* attribute) {
|
|
if (!other.holds_alternative<T>()) {
|
|
return false;
|
|
}
|
|
absl::optional<T> attribute_as_optional =
|
|
attribute->has_value() ? absl::optional<T>(attribute->value())
|
|
: absl::nullopt;
|
|
return attribute_as_optional == other.as_optional<T>();
|
|
}
|
|
|
|
const Attribute& other;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
const char* Attribute::name() const {
|
|
return name_;
|
|
}
|
|
|
|
const Attribute::StatVariant& Attribute::as_variant() const {
|
|
return attribute_;
|
|
}
|
|
|
|
bool Attribute::has_value() const {
|
|
return absl::visit([](const auto* attr) { return attr->has_value(); },
|
|
attribute_);
|
|
}
|
|
|
|
bool Attribute::is_sequence() const {
|
|
return absl::visit(VisitIsSequence(), attribute_);
|
|
}
|
|
|
|
bool Attribute::is_string() const {
|
|
return absl::holds_alternative<const RTCStatsMember<std::string>*>(
|
|
attribute_);
|
|
}
|
|
|
|
std::string Attribute::ValueToString() const {
|
|
return absl::visit([](const auto* attr) { return attr->ValueToString(); },
|
|
attribute_);
|
|
}
|
|
|
|
std::string Attribute::ValueToJson() const {
|
|
return absl::visit([](const auto* attr) { return attr->ValueToJson(); },
|
|
attribute_);
|
|
}
|
|
|
|
bool Attribute::operator==(const Attribute& other) const {
|
|
return absl::visit(VisitIsEqual{.other = other}, attribute_);
|
|
}
|
|
|
|
bool Attribute::operator!=(const Attribute& other) const {
|
|
return !(*this == other);
|
|
}
|
|
|
|
AttributeInit::AttributeInit(const char* name,
|
|
const Attribute::StatVariant& variant)
|
|
: name(name), variant(variant) {}
|
|
|
|
} // namespace webrtc
|