e3b74f8e61
When an SCTP stream is closing, a stream reset needs to be sent from both ends. The remote was not sending a stream reset and quickly opening another stream with the same StreamID could cause SCTP errors. Bug: webrtc:13994 Change-Id: I3abc74ddc88b3fcf7e6495d76e7d77f52280b5d1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260922 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36773}
130 lines
4.9 KiB
C++
130 lines
4.9 KiB
C++
/*
|
|
* Copyright 2022 The WebRTC project authors. All Rights Reserved.
|
|
*
|
|
* Use of this source code is governed by a BSD-style license
|
|
* that can be found in the LICENSE file in the root of the source
|
|
* tree. An additional intellectual property rights grant can be found
|
|
* in the file PATENTS. All contributing project authors may
|
|
* be found in the AUTHORS file in the root of the source tree.
|
|
*/
|
|
|
|
#include "media/sctp/dcsctp_transport.h"
|
|
|
|
#include <memory>
|
|
#include <utility>
|
|
|
|
#include "net/dcsctp/public/mock_dcsctp_socket.h"
|
|
#include "net/dcsctp/public/mock_dcsctp_socket_factory.h"
|
|
#include "p2p/base/fake_packet_transport.h"
|
|
#include "test/gtest.h"
|
|
|
|
using ::testing::ByMove;
|
|
using ::testing::DoAll;
|
|
using ::testing::ElementsAre;
|
|
using ::testing::InSequence;
|
|
using ::testing::Invoke;
|
|
using ::testing::NiceMock;
|
|
using ::testing::Return;
|
|
|
|
namespace webrtc {
|
|
|
|
namespace {
|
|
class SctpInternalTransportObserver : public sigslot::has_slots<> {
|
|
public:
|
|
MOCK_METHOD(void, OnSignalReadyToSendData, ());
|
|
MOCK_METHOD(void, OnSignalAssociationChangeCommunicationUp, ());
|
|
MOCK_METHOD(void, OnSignalClosingProcedureStartedRemotely, (int));
|
|
MOCK_METHOD(void, OnSignalClosingProcedureComplete, (int));
|
|
};
|
|
|
|
class Peer {
|
|
public:
|
|
Peer() : fake_packet_transport_("transport"), simulated_clock_(1000) {
|
|
auto socket_ptr = std::make_unique<dcsctp::MockDcSctpSocket>();
|
|
socket_ = socket_ptr.get();
|
|
|
|
auto mock_dcsctp_socket_factory =
|
|
std::make_unique<dcsctp::MockDcSctpSocketFactory>();
|
|
EXPECT_CALL(*mock_dcsctp_socket_factory, Create)
|
|
.Times(1)
|
|
.WillOnce(Return(ByMove(std::move(socket_ptr))));
|
|
|
|
sctp_transport_ = std::make_unique<webrtc::DcSctpTransport>(
|
|
rtc::Thread::Current(), &fake_packet_transport_, &simulated_clock_,
|
|
std::move(mock_dcsctp_socket_factory));
|
|
|
|
sctp_transport_->SignalAssociationChangeCommunicationUp.connect(
|
|
static_cast<SctpInternalTransportObserver*>(&observer_),
|
|
&SctpInternalTransportObserver::OnSignalReadyToSendData);
|
|
sctp_transport_->SignalAssociationChangeCommunicationUp.connect(
|
|
static_cast<SctpInternalTransportObserver*>(&observer_),
|
|
&SctpInternalTransportObserver::
|
|
OnSignalAssociationChangeCommunicationUp);
|
|
sctp_transport_->SignalClosingProcedureStartedRemotely.connect(
|
|
static_cast<SctpInternalTransportObserver*>(&observer_),
|
|
&SctpInternalTransportObserver::
|
|
OnSignalClosingProcedureStartedRemotely);
|
|
sctp_transport_->SignalClosingProcedureComplete.connect(
|
|
static_cast<SctpInternalTransportObserver*>(&observer_),
|
|
&SctpInternalTransportObserver::OnSignalClosingProcedureComplete);
|
|
}
|
|
|
|
rtc::FakePacketTransport fake_packet_transport_;
|
|
webrtc::SimulatedClock simulated_clock_;
|
|
dcsctp::MockDcSctpSocket* socket_;
|
|
std::unique_ptr<webrtc::DcSctpTransport> sctp_transport_;
|
|
NiceMock<SctpInternalTransportObserver> observer_;
|
|
};
|
|
} // namespace
|
|
|
|
TEST(DcSctpTransportTest, OpenSequence) {
|
|
Peer peer_a;
|
|
peer_a.fake_packet_transport_.SetWritable(true);
|
|
|
|
EXPECT_CALL(*peer_a.socket_, Connect)
|
|
.Times(1)
|
|
.WillOnce(Invoke(peer_a.sctp_transport_.get(),
|
|
&dcsctp::DcSctpSocketCallbacks::OnConnected));
|
|
EXPECT_CALL(peer_a.observer_, OnSignalReadyToSendData);
|
|
EXPECT_CALL(peer_a.observer_, OnSignalAssociationChangeCommunicationUp);
|
|
|
|
peer_a.sctp_transport_->Start(5000, 5000, 256 * 1024);
|
|
}
|
|
|
|
TEST(DcSctpTransportTest, CloseSequence) {
|
|
Peer peer_a;
|
|
Peer peer_b;
|
|
peer_a.fake_packet_transport_.SetDestination(&peer_b.fake_packet_transport_,
|
|
false);
|
|
{
|
|
InSequence sequence;
|
|
|
|
EXPECT_CALL(*peer_a.socket_, ResetStreams(ElementsAre(dcsctp::StreamID(1))))
|
|
.WillOnce(DoAll(
|
|
Invoke(peer_b.sctp_transport_.get(),
|
|
&dcsctp::DcSctpSocketCallbacks::OnIncomingStreamsReset),
|
|
Invoke(peer_a.sctp_transport_.get(),
|
|
&dcsctp::DcSctpSocketCallbacks::OnStreamsResetPerformed),
|
|
Return(dcsctp::ResetStreamsStatus::kPerformed)));
|
|
|
|
EXPECT_CALL(*peer_b.socket_, ResetStreams(ElementsAre(dcsctp::StreamID(1))))
|
|
.WillOnce(DoAll(
|
|
Invoke(peer_a.sctp_transport_.get(),
|
|
&dcsctp::DcSctpSocketCallbacks::OnIncomingStreamsReset),
|
|
Invoke(peer_b.sctp_transport_.get(),
|
|
&dcsctp::DcSctpSocketCallbacks::OnStreamsResetPerformed),
|
|
Return(dcsctp::ResetStreamsStatus::kPerformed)));
|
|
|
|
EXPECT_CALL(peer_a.observer_, OnSignalClosingProcedureComplete(1));
|
|
EXPECT_CALL(peer_b.observer_, OnSignalClosingProcedureComplete(1));
|
|
EXPECT_CALL(peer_b.observer_, OnSignalClosingProcedureStartedRemotely(1));
|
|
}
|
|
|
|
peer_a.sctp_transport_->Start(5000, 5000, 256 * 1024);
|
|
peer_b.sctp_transport_->Start(5000, 5000, 256 * 1024);
|
|
peer_a.sctp_transport_->OpenStream(1);
|
|
peer_a.sctp_transport_->ResetStream(1);
|
|
}
|
|
|
|
} // namespace webrtc
|