cd3d29b6fb
Before this CL, the StreamId class represented either a valid SCTP stream ID, or "nothing", which means that it was a wrapped absl::optional. Since created data channels don't have a SCTP stream ID until it's known whether this peer will use odd or even numbers, the "nothing" value was used for that state. This unfortunately made it a bit hard to work with objects of this type, as one always had to check if it contained a value. And even if a caller would check this, and then pass the StreamId to a different function, that function would have to do the check itself (often as a RTC_DCHECK) since the passed StreamId always could have that state. This CL simply extracts the "absl::optional" part of it, forcing holders to wrap it in an optional type - when it can be "nothing". But allowing the other code to just pass StreamId that can't be "nothing". That simplifies the code a bit, potentially removing some bugs. Bug: chromium:41221056 Change-Id: I93104cdd5d2f5fc1dbeb9d9dfc4cf361f11a9d68 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/342440 Reviewed-by: Florent Castelli <orphis@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Victor Boivie <boivie@webrtc.org> Cr-Commit-Position: refs/heads/main@{#41880}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
Development
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.
More info
- Official web site: http://www.webrtc.org
- Master source code repo: https://webrtc.googlesource.com/src
- Samples and reference apps: https://github.com/webrtc
- Mailing list: http://groups.google.com/group/discuss-webrtc
- Continuous build: https://ci.chromium.org/p/webrtc/g/ci/console
- Coding style guide
- Code of conduct
- Reporting bugs
- Documentation