ccab06fb72
This reverts commit b0e0728159f07269a875c5b53658603cf6733480. Reason for revert: Causes Chromium tests to timeout, preventing rolls into Chromium. Original change's description: > Replaces SynchronousMethodCall with rtc::Thread::Invoke. > > Given that we already have Thread:.Invoke that can be used with lambda, > SynchronousMethodCall doesn't add any value. > > This simplification prepares for simulated time peer connection tests. > > Bug: webrtc:11255 > Change-Id: I478a11f15e30e009dae4a3fee2120f6d7a03355f > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/165683 > Commit-Queue: Sebastian Jansson <srte@webrtc.org> > Reviewed-by: Steve Anton <steveanton@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30217} TBR=steveanton@webrtc.org,srte@webrtc.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11255 Change-Id: I9d3aa218013129db7a09a77500a0547ce9ae341a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166047 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/heads/master@{#30265}
How to write code in the api/ directory
Mostly, just follow the regular style guide, but:
- Note that
api/code is not exempt from the “.hand.ccfiles come in pairs” rule, so if you declare something inapi/path/to/foo.h, it should be defined inapi/path/to/foo.cc. - Headers in
api/should, if possible, not#includeheaders outsideapi/. It’s not always possible to avoid this, but be aware that it adds to a small mountain of technical debt that we’re trying to shrink. .ccfiles inapi/, on the other hand, are free to#includeheaders outsideapi/.
That is, the preferred way for api/ code to access non-api/ code is to call
it from a .cc file, so that users of our API headers won’t transitively
#include non-public headers.
For headers in api/ that need to refer to non-public types, forward
declarations are often a lesser evil than including non-public header files. The
usual rules still apply, though.
.cc files in api/ should preferably be kept reasonably small. If a
substantial implementation is needed, consider putting it with our non-public
code, and just call it from the api/ .cc file.